* [PATCH] Disable PowerMac cpufreq on SMP kernels
@ 2009-08-11 9:39 Bastian Blank
2009-08-13 6:14 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Bastian Blank @ 2009-08-11 9:39 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel, Benjamin Herrenschmidt
The build of a PowerMac 32bit kernel currently fails with
error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
This patch just disables this driver on SMP kernels, as it is obviously
not supported.
Signed-off-by: Bastian Blank <waldi@debian.org>
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 04a8061..99d3564 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -149,7 +149,7 @@ menu "CPU Frequency drivers"
config CPU_FREQ_PMAC
bool "Support for Apple PowerBooks"
- depends on ADB_PMU && PPC32
+ depends on ADB_PMU && PPC32 && !SMP
select CPU_FREQ_TABLE
help
This adds support for frequency switching on Apple PowerBooks,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Disable PowerMac cpufreq on SMP kernels
2009-08-11 9:39 [PATCH] Disable PowerMac cpufreq on SMP kernels Bastian Blank
@ 2009-08-13 6:14 ` Benjamin Herrenschmidt
2009-08-13 9:30 ` [PATCH] Remove SMP warning from PowerMac cpufreq Bastian Blank
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2009-08-13 6:14 UTC (permalink / raw)
To: Bastian Blank; +Cc: linuxppc-dev, linux-kernel
On Tue, 2009-08-11 at 11:39 +0200, Bastian Blank wrote:
> The build of a PowerMac 32bit kernel currently fails with
>
> error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
>
> This patch just disables this driver on SMP kernels, as it is obviously
> not supported.
>
> Signed-off-by: Bastian Blank <waldi@debian.org>
Why not remove the #error instead ? :-) I don't think it's still
meaningful, especially since we use the timebase for delays nowadays
which doesn't depend on the CPU frequency...
Ben.
> diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
> index 04a8061..99d3564 100644
> --- a/arch/powerpc/platforms/Kconfig
> +++ b/arch/powerpc/platforms/Kconfig
> @@ -149,7 +149,7 @@ menu "CPU Frequency drivers"
>
> config CPU_FREQ_PMAC
> bool "Support for Apple PowerBooks"
> - depends on ADB_PMU && PPC32
> + depends on ADB_PMU && PPC32 && !SMP
> select CPU_FREQ_TABLE
> help
> This adds support for frequency switching on Apple PowerBooks,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove SMP warning from PowerMac cpufreq
2009-08-13 6:14 ` Benjamin Herrenschmidt
@ 2009-08-13 9:30 ` Bastian Blank
0 siblings, 0 replies; 3+ messages in thread
From: Bastian Blank @ 2009-08-13 9:30 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-kernel
On Thu, Aug 13, 2009 at 04:14:58PM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2009-08-11 at 11:39 +0200, Bastian Blank wrote:
> > This patch just disables this driver on SMP kernels, as it is obviously
> > not supported.
> Why not remove the #error instead ? :-) I don't think it's still
> meaningful, especially since we use the timebase for delays nowadays
> which doesn't depend on the CPU frequency...
Your call. Take this one:
The build of a PowerMac 32bit kernel currently fails with
error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
Thie patch removes the not longer applicable SMP warning from the
PowerMac cpufreq code.
Signed-off-by: Bastian Blank <waldi@debian.org>
diff --git a/arch/powerpc/platforms/powermac/cpufreq_32.c b/arch/powerpc/platforms/powermac/cpufreq_32.c
index 65c585b..08d94e4 100644
--- a/arch/powerpc/platforms/powermac/cpufreq_32.c
+++ b/arch/powerpc/platforms/powermac/cpufreq_32.c
@@ -44,14 +44,6 @@
*/
#undef DEBUG_FREQ
-/*
- * There is a problem with the core cpufreq code on SMP kernels,
- * it won't recalculate the Bogomips properly
- */
-#ifdef CONFIG_SMP
-#warning "WARNING, CPUFREQ not recommended on SMP kernels"
-#endif
-
extern void low_choose_7447a_dfs(int dfs);
extern void low_choose_750fx_pll(int pll);
extern void low_sleep_handler(void);
--
Those who hate and fight must stop themselves -- otherwise it is not stopped.
-- Spock, "Day of the Dove", stardate unknown
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-13 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-11 9:39 [PATCH] Disable PowerMac cpufreq on SMP kernels Bastian Blank
2009-08-13 6:14 ` Benjamin Herrenschmidt
2009-08-13 9:30 ` [PATCH] Remove SMP warning from PowerMac cpufreq Bastian Blank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).