* [PATCH] powerpc: Quieten cede latency printk
@ 2010-02-07 23:52 Anton Blanchard
2010-02-08 11:07 ` Balbir Singh
0 siblings, 1 reply; 3+ messages in thread
From: Anton Blanchard @ 2010-02-07 23:52 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev
The cede latency stuff is relatively new and we don't need to complain about
it not working on older firmware.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: powerpc.git/arch/powerpc/platforms/pseries/hotplug-cpu.c
===================================================================
--- powerpc.git.orig/arch/powerpc/platforms/pseries/hotplug-cpu.c 2010-02-05 17:36:22.509710985 +1100
+++ powerpc.git/arch/powerpc/platforms/pseries/hotplug-cpu.c 2010-02-05 17:36:30.118124726 +1100
@@ -396,14 +396,6 @@ static int parse_cede_parameters(void)
__pa(cede_parameters),
CEDE_LATENCY_PARAM_MAX_LENGTH);
- if (call_status != 0)
- printk(KERN_INFO "CEDE_LATENCY: \
- %s %s Error calling get-system-parameter(0x%x)\n",
- __FILE__, __func__, call_status);
- else
- printk(KERN_INFO "CEDE_LATENCY: \
- get-system-parameter successful.\n");
-
return call_status;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Quieten cede latency printk
2010-02-07 23:52 [PATCH] powerpc: Quieten cede latency printk Anton Blanchard
@ 2010-02-08 11:07 ` Balbir Singh
2010-02-08 12:56 ` Vaidyanathan Srinivasan
0 siblings, 1 reply; 3+ messages in thread
From: Balbir Singh @ 2010-02-08 11:07 UTC (permalink / raw)
To: Anton Blanchard; +Cc: linuxppc-dev, Gautham R Shenoy
On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard <anton@samba.org> wrote:
>
> The cede latency stuff is relatively new and we don't need to complain about
> it not working on older firmware.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
Seems like a reasonable change. CC'ing Vaidy and Gautham to look even
more closely at the patch.
Balbir
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Quieten cede latency printk
2010-02-08 11:07 ` Balbir Singh
@ 2010-02-08 12:56 ` Vaidyanathan Srinivasan
0 siblings, 0 replies; 3+ messages in thread
From: Vaidyanathan Srinivasan @ 2010-02-08 12:56 UTC (permalink / raw)
To: Balbir Singh; +Cc: linuxppc-dev, Anton Blanchard, Gautham R Shenoy
* Balbir Singh <balbir@linux.vnet.ibm.com> [2010-02-08 16:37:37]:
> On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard <anton@samba.org> wrote:
> >
> > The cede latency stuff is relatively new and we don't need to complain about
> > it not working on older firmware.
> >
> > Signed-off-by: Anton Blanchard <anton@samba.org>
>
> Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>
> Seems like a reasonable change. CC'ing Vaidy and Gautham to look even
> more closely at the patch.
Hi Anton,
Removing the printk is reasonable. The failure case is noise in older
firmware while the success case may not be very informative.
Thanks,
Vaidy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-08 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-07 23:52 [PATCH] powerpc: Quieten cede latency printk Anton Blanchard
2010-02-08 11:07 ` Balbir Singh
2010-02-08 12:56 ` Vaidyanathan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).