linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: linuxppc-dev list <Linuxppc-dev@ozlabs.org>,
	Torez Smith <torez@us.ibm.com>
Subject: Re: [RFC: PATCH 03/13] powerpc/47x: Base ppc476 support
Date: Mon, 1 Mar 2010 15:19:00 -0500	[thread overview]
Message-ID: <20100301201900.GA8963@zod.rchland.ibm.com> (raw)
In-Reply-To: <20100301191315.20987.48063.sendpatchset@norville.austin.ibm.com>

Overall I'm just going to trust you that things aren't broken on 47x :)

A few minor comments below.  Also, if Torez and Benh contributed to this code,
then their S-o-b lines should be included as well (same goes for any other
patch).

On Mon, Mar 01, 2010 at 12:13:15PM -0700, Dave Kleikamp wrote:
>diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h
>index bc8dd53..4af1c28 100644
>--- a/arch/powerpc/include/asm/reg.h
>+++ b/arch/powerpc/include/asm/reg.h
>@@ -813,6 +813,7 @@
> #define PVR_403GC	0x00200200
> #define PVR_403GCX	0x00201400
> #define PVR_405GP	0x40110000
>+#define PVR_476		0x11a52000

Is that really needed?  None of the 44x CPUs have a PVR value here.

> #define PVR_STB03XXX	0x40310000
> #define PVR_NP405H	0x41410000
> #define PVR_NP405L	0x41610000

<snip>

>diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
>index 2fc82ba..338ac47 100644
>--- a/arch/powerpc/kernel/cputable.c
>+++ b/arch/powerpc/kernel/cputable.c
>@@ -1701,6 +1701,19 @@ static struct cpu_spec __initdata cpu_specs[] = {
> 		.machine_check		= machine_check_440A,
> 		.platform		= "ppc440",
> 	},
>+	{ /* 476 core */
>+		.pvr_mask		= 0xffff0000,
>+		.pvr_value		= 0x11a50000,

Could we use PVR_476 here (if it's going to stay).

>+		.cpu_name		= "476",
>+		.cpu_features		= CPU_FTRS_47X,
>+		.cpu_user_features	= COMMON_USER_BOOKE |
>+			PPC_FEATURE_HAS_FPU,
>+		.mmu_features		= MMU_FTR_TYPE_47x |
>+			MMU_FTR_USE_TLBIVAX_BCAST | MMU_FTR_LOCK_BCAST_INVAL,
>+		.icache_bsize		= 32,
>+		.dcache_bsize		= 128,
>+		.platform		= "ppc470",
>+	},

<snip>

>diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
>index 7486bff..1dfc1c1 100644
>--- a/arch/powerpc/platforms/44x/Kconfig
>+++ b/arch/powerpc/platforms/44x/Kconfig
>@@ -1,6 +1,17 @@
>+config PPC_44x_46x
>+	bool "Support for 44x and 46x variants"
>+	depends on 44x
>+	default n

Why do this?  All it seems to do is add a bunch of churn to the Kconfig here.
If the intention was to try and prevent selecting both 44x and 47x kernel
options, then maybe I could see that.  However nothing prevents both from being
enabled.  Maybe PPC_47x should:

depends on !PPC_44x_46x && 44x

josh

  reply	other threads:[~2010-03-01 20:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01 19:12 [RFC: PATCH 00/13] powerpc/47x: Support for 476 core Dave Kleikamp
2010-03-01 12:13 ` [RFC: PATCH 04/13] powerpc/476: add machine check handler for 47x core Dave Kleikamp
2010-03-01 21:08   ` Olof Johansson
2010-03-01 23:22     ` Dave Kleikamp
2010-03-01 19:13 ` [RFC: PATCH 01/13] powerpc/booke: Add Stack Marking support to Booke Exception Prolog Dave Kleikamp
2010-03-02 14:50   ` Kumar Gala
2010-03-02 15:09     ` Dave Kleikamp
2010-03-01 19:13 ` [RFC: PATCH 02/13] powerpc/44x: break out cpu init code into stand-alone function Dave Kleikamp
2010-03-01 19:13 ` [RFC: PATCH 03/13] powerpc/47x: Base ppc476 support Dave Kleikamp
2010-03-01 20:19   ` Josh Boyer [this message]
2010-03-01 23:11     ` Dave Kleikamp
2010-03-02  0:47       ` Josh Boyer
2010-03-01 19:13 ` [RFC: PATCH 05/13] powerpc/476: Add isync after loading mmu and debug spr's Dave Kleikamp
2010-03-01 19:13 ` [RFC: PATCH 07/13] powerpc/47x: defconfig for 476 on the iss 4xx simulator Dave Kleikamp
2010-03-01 19:13 ` [RFC: PATCH 08/13] powerpc/476: define specific cpu table entry for DD1 and DD1.1 cores Dave Kleikamp
2010-03-01 20:24   ` Josh Boyer
2010-03-01 23:43     ` Dave Kleikamp
2010-03-04 17:06   ` Hollis Blanchard
2010-03-05  9:15     ` Kumar Gala
2010-03-05 13:18       ` Dave Kleikamp
2010-03-01 19:13 ` [RFC: PATCH 09/13] powerpc/476: Workaround for dcbf/dcbz workaround on DD1 Dave Kleikamp
2010-03-01 19:14 ` [RFC: PATCH 10/13] powerpc/476: Add isync to the top of all exception handlers for DD1.1 core Dave Kleikamp
2010-03-01 19:14 ` [RFC: PATCH 11/13] powerpc/476: Software workaround to fix dcr read/write sequencing Dave Kleikamp
2010-03-01 19:14 ` [RFC: PATCH 12/13] powerpc/476: Workaround for DD1.1: Issue lwsync after mtpid Dave Kleikamp
2010-03-01 19:14 ` [RFC: PATCH 13/13] powerpc/476: Add dci instruction to async interrupt handlers on DD1 core Dave Kleikamp
2010-03-01 19:16 ` [RFC: PATCH 06/13] powerpc/4xx: Simple platform for the ISS 4xx simulator Dave Kleikamp
2010-03-01 20:29   ` Josh Boyer
2010-03-01 23:33     ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100301201900.GA8963@zod.rchland.ibm.com \
    --to=jwboyer@linux.vnet.ibm.com \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=shaggy@linux.vnet.ibm.com \
    --cc=torez@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).