* [PATCH] powerpc: cell: Fix axion_msi irq shutdown
@ 2010-09-28 15:11 Thomas Gleixner
2010-09-28 15:13 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Gleixner @ 2010-09-28 15:11 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linuxppc-dev
Calling unmask_msi_irq on irq shutdown is at least suboptimal.
Use mask_msi_irq instead.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/powerpc/platforms/cell/axon_msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/powerpc/platforms/cell/axon_msi.c
===================================================================
--- linux-2.6.orig/arch/powerpc/platforms/cell/axon_msi.c
+++ linux-2.6/arch/powerpc/platforms/cell/axon_msi.c
@@ -312,7 +312,7 @@ static void axon_msi_teardown_msi_irqs(s
static struct irq_chip msic_irq_chip = {
.mask = mask_msi_irq,
.unmask = unmask_msi_irq,
- .shutdown = unmask_msi_irq,
+ .shutdown = mask_msi_irq,
.name = "AXON-MSI",
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: cell: Fix axion_msi irq shutdown
2010-09-28 15:11 [PATCH] powerpc: cell: Fix axion_msi irq shutdown Thomas Gleixner
@ 2010-09-28 15:13 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2010-09-28 15:13 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linuxppc-dev
On Tuesday 28 September 2010, Thomas Gleixner wrote:
> Calling unmask_msi_irq on irq shutdown is at least suboptimal.
> Use mask_msi_irq instead.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-28 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-28 15:11 [PATCH] powerpc: cell: Fix axion_msi irq shutdown Thomas Gleixner
2010-09-28 15:13 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).