linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"
@ 2011-02-23 20:54 Moffett, Kyle D
  2011-02-23 22:11 ` Anton Blanchard
  0 siblings, 1 reply; 2+ messages in thread
From: Moffett, Kyle D @ 2011-02-23 20:54 UTC (permalink / raw)
  To: linuxppc-dev, linux-kernel
  Cc: Anton Blanchard, Livingston, John A, Matthew McClintock

Hello everyone,

I just started trying to update some patches for our P2020-based unit to th=
e latest Linus upstream, hoping to take advantage of the recent mpc85xx kex=
ec() support.

Unfortunately I'm getting a compile error:

arch/powerpc/platforms/85xx/smp.c:241: error: 'struct machdep_calls' has no=
 member named 'machine_kexec'

As far as I can tell, "machine_kexec" was removed in commit c9486878 (power=
pc/kexec: Remove ppc_md.machine_kexec) on Jan 6th, 2011, which claims that =
it was not used.

Unfortunately it looks like it *is* used by the mpc85xx kexec() support (co=
mmit f933a41e), added on Jul 21, 2010.

Cheers,
Kyle Moffett

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"
  2011-02-23 20:54 mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec" Moffett, Kyle D
@ 2011-02-23 22:11 ` Anton Blanchard
  0 siblings, 0 replies; 2+ messages in thread
From: Anton Blanchard @ 2011-02-23 22:11 UTC (permalink / raw)
  To: Moffett, Kyle D
  Cc: linuxppc-dev, linux-kernel, Livingston, John A, Matthew McClintock


Hi Kyle,

> As far as I can tell, "machine_kexec" was removed in commit c9486878
> (powerpc/kexec: Remove ppc_md.machine_kexec) on Jan 6th, 2011, which
> claims that it was not used.
> 
> Unfortunately it looks like it *is* used by the mpc85xx kexec()
> support (commit f933a41e), added on Jul 21, 2010.

Thanks for the report. Testing a patch now.

Anton

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-23 22:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-23 20:54 mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec" Moffett, Kyle D
2011-02-23 22:11 ` Anton Blanchard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).