linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Timur Tabi <timur@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice
Date: Tue, 27 Mar 2012 23:01:55 -0600	[thread overview]
Message-ID: <20120328050155.BC5143E0C37@localhost> (raw)
In-Reply-To: <4F720462.5020400@freescale.com>

On Tue, 27 Mar 2012 13:18:10 -0500, Timur Tabi <timur@freescale.com> wrote:
> Grant, do you have a moment to consider my question?  Like I said, I'm
> anxious to get a fix into 3.3.

I've been out of town for the past week, so email processing volume
has been low.  Answer below.

> Timur Tabi wrote:
> > Timur Tabi wrote:
> >> They only problem I see with this is that I am thinking about modifying
> >> the drivers/dma driver to probe on "fsl,eloplus-dma-channel" channels
> >> directly.  If I do that, then who should call of_platform_populate()?
> > 
> > Grant, could you tell me if there's anything actually work with my patch?
> >  All I'm doing is adding a couple more commonly used entries to
> > mpc85xx_common_ids[].  After all, they're common IDs, so don't they belong
> > into an array called common_ids?

That's between you and Kumar.  I don't have any problem with it since
it's all contained within the mpc85xx code.

If those nodes really do make sense to represent as independent
platform devices, then adding them to the match list for bus types
isn't a problem.

g.

  reply	other threads:[~2012-03-28  5:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 16:19 [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice Timur Tabi
2012-03-07 21:41 ` Timur Tabi
2012-03-16 20:46 ` Kumar Gala
2012-03-16 20:50   ` Timur Tabi
2012-03-19 16:04     ` Grant Likely
2012-03-19 18:43       ` Timur Tabi
2012-03-20 17:09         ` Grant Likely
2012-03-20 17:25           ` Timur Tabi
2012-03-21 15:15             ` Timur Tabi
2012-03-27 18:18               ` Timur Tabi
2012-03-28  5:01                 ` Grant Likely [this message]
2012-03-21 15:08       ` Kumar Gala
2012-04-19 20:15 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120328050155.BC5143E0C37@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=dbaryshkov@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).