linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice
Date: Fri, 16 Mar 2012 15:50:44 -0500	[thread overview]
Message-ID: <4F63A7A4.4000205@freescale.com> (raw)
In-Reply-To: <F8C3451C-1B14-4C30-A194-B15B6C10B0A7@kernel.crashing.org>

Kumar Gala wrote:

> This seems like paper taping over the real issue.  We should be able to call of_platform_bus_probe() multiple times.

I tried debugging it, but I couldn't figure it out.  My guess is that the
nodes probed by of_platform_bus_probe() are somehow "reserved", so that
the second time it's called, they're skipped.  I figured that this was
just a side-effect of the way the OF layer works.

If someone more familiar with the OF layer wants to look at it, that's
great.  Until then, my patch is the only one that allows the audio and
async DMA drivers to work, and any other drivers that probe on nodes that
are grandchildren of the root node.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-03-16 20:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 16:19 [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice Timur Tabi
2012-03-07 21:41 ` Timur Tabi
2012-03-16 20:46 ` Kumar Gala
2012-03-16 20:50   ` Timur Tabi [this message]
2012-03-19 16:04     ` Grant Likely
2012-03-19 18:43       ` Timur Tabi
2012-03-20 17:09         ` Grant Likely
2012-03-20 17:25           ` Timur Tabi
2012-03-21 15:15             ` Timur Tabi
2012-03-27 18:18               ` Timur Tabi
2012-03-28  5:01                 ` Grant Likely
2012-03-21 15:08       ` Kumar Gala
2012-04-19 20:15 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F63A7A4.4000205@freescale.com \
    --to=timur@freescale.com \
    --cc=dbaryshkov@gmail.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).