From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Hugh Dickins <hughd@google.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paul.mckenney@linaro.org>
Subject: Re: linux-next ppc64: RCU mods cause __might_sleep BUGs
Date: Mon, 7 May 2012 11:50:17 -0700 [thread overview]
Message-ID: <20120507185017.GA21152@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1205070858450.1416@eggly.anvils>
On Mon, May 07, 2012 at 09:21:54AM -0700, Hugh Dickins wrote:
> On Wed, 2 May 2012, Hugh Dickins wrote:
> > On Wed, 2 May 2012, Paul E. McKenney wrote:
> > >
> > > In any case, I must confess that I feel quite silly about my series
> > > of patches. I have reverted them aside from a couple that did useful
> > > optimizations, and they should show up in -next shortly.
> >
> > A wee bit sad, but thank you - it was an experiment worth trying,
> > and perhaps there will be reason to come back to it future.
>
> The revert indeed showed up in next-20120504: thanks, no problem now.
>
> But although it's just history, and not worth anyone's time to
> investigate, I shouldn't let this thread die without an epilogue.
>
> Although the patch I posted (this_cpu_inc in __rcu_read_lock,
> preempt_disable and enable in __rcu_read_unlock) ran well until
> I killed the test after 70 hours, it did not _entirely_ eliminate
> the sleeping function BUG messages.
>
> In 70 hours I got six isolated messages like the below (but from
> different __might_sleep callsites) - where before I'd have flurries
> of hundreds(?) and freeze within the hour.
>
> And the "rcu_nesting" debug line I'd added to the message was different:
> where before it was showing ffffffff on some tasks and 1 on others i.e.
> increment or decrement had been applied to the wrong task, these messages
> now all showed 0s throughout i.e. by the time the message was printed,
> there was no longer any justification for the message.
>
> As if a memory barrier were missing somewhere, perhaps.
These fields should be updated only by the corresponding CPU, so
if memory barriers are needed, it seems to me that the cross-CPU
access is the bug, not the lack of a memory barrier.
Ah... Is preemption disabled across the access to RCU's nesting level
when printing out the message? If not, a preeemption at that point
could result in the value printed being inaccurate.
Thanx, Paul
> BUG: sleeping function called from invalid context at arch/powerpc/mm/fault.c:305
> cpu=2 preempt_count=0 preempt_offset=0 rcu_nesting=0 nesting_save=0
> in_atomic(): 0, irqs_disabled(): 0, pid: 12266, name: cc1
> Call Trace:
> [c000000003affac0] [c00000000000f36c] .show_stack+0x6c/0x16c (unreliable)
> [c000000003affb70] [c000000000078788] .__might_sleep+0x150/0x170
> [c000000003affc00] [c0000000000255f4] .do_page_fault+0x288/0x664
> [c000000003affe30] [c000000000005868] handle_page_fault+0x10/0x30
>
> Hugh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2012-05-07 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 22:37 linux-next ppc64: RCU mods cause __might_sleep BUGs Hugh Dickins
2012-04-30 23:14 ` Paul E. McKenney
2012-05-01 0:33 ` Benjamin Herrenschmidt
2012-05-01 5:10 ` Hugh Dickins
2012-05-01 14:22 ` Paul E. McKenney
2012-05-01 21:42 ` Hugh Dickins
2012-05-01 23:25 ` Paul E. McKenney
2012-05-02 20:25 ` Hugh Dickins
2012-05-02 20:49 ` Paul E. McKenney
2012-05-02 21:32 ` Paul E. McKenney
2012-05-02 21:36 ` Paul E. McKenney
2012-05-02 21:20 ` Benjamin Herrenschmidt
2012-05-02 21:54 ` Paul E. McKenney
2012-05-02 22:54 ` Hugh Dickins
2012-05-03 0:14 ` Paul E. McKenney
2012-05-03 0:24 ` Hugh Dickins
2012-05-07 16:21 ` Hugh Dickins
2012-05-07 18:50 ` Paul E. McKenney [this message]
2012-05-07 21:38 ` Hugh Dickins
2012-05-01 13:39 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507185017.GA21152@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=cl@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul.mckenney@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).