* [PATCH] powerpc: Fix size of st_nlink on 64bit
@ 2012-06-02 11:34 Anton Blanchard
2012-06-02 21:19 ` Benjamin Herrenschmidt
2012-06-03 2:28 ` Stephen Rothwell
0 siblings, 2 replies; 5+ messages in thread
From: Anton Blanchard @ 2012-06-02 11:34 UTC (permalink / raw)
To: benh, paulus, michael, viro; +Cc: linuxppc-dev
commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to
explicitly-sized type) changed the size of st_nlink on ppc64 from
a long to a short, resulting in boot failures.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux-build/arch/powerpc/include/asm/stat.h
===================================================================
--- linux-build.orig/arch/powerpc/include/asm/stat.h 2012-06-02 21:25:50.322275743 +1000
+++ linux-build/arch/powerpc/include/asm/stat.h 2012-06-02 21:26:35.183130538 +1000
@@ -30,7 +30,7 @@ struct stat {
unsigned long st_dev;
ino_t st_ino;
#ifdef __powerpc64__
- unsigned short st_nlink;
+ unsigned long st_nlink;
mode_t st_mode;
#else
mode_t st_mode;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: Fix size of st_nlink on 64bit
2012-06-02 11:34 [PATCH] powerpc: Fix size of st_nlink on 64bit Anton Blanchard
@ 2012-06-02 21:19 ` Benjamin Herrenschmidt
2012-06-03 2:28 ` Stephen Rothwell
1 sibling, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2012-06-02 21:19 UTC (permalink / raw)
To: Anton Blanchard; +Cc: michael, linuxppc-dev, paulus, viro
On Sat, 2012-06-02 at 21:34 +1000, Anton Blanchard wrote:
> commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to
> explicitly-sized type) changed the size of st_nlink on ppc64 from
> a long to a short, resulting in boot failures.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Al, did you CC me on that ? I don't remember seeing it but it could be
my fault...
Cheers,
Ben.
> ---
>
> Index: linux-build/arch/powerpc/include/asm/stat.h
> ===================================================================
> --- linux-build.orig/arch/powerpc/include/asm/stat.h 2012-06-02 21:25:50.322275743 +1000
> +++ linux-build/arch/powerpc/include/asm/stat.h 2012-06-02 21:26:35.183130538 +1000
> @@ -30,7 +30,7 @@ struct stat {
> unsigned long st_dev;
> ino_t st_ino;
> #ifdef __powerpc64__
> - unsigned short st_nlink;
> + unsigned long st_nlink;
> mode_t st_mode;
> #else
> mode_t st_mode;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: Fix size of st_nlink on 64bit
2012-06-02 11:34 [PATCH] powerpc: Fix size of st_nlink on 64bit Anton Blanchard
2012-06-02 21:19 ` Benjamin Herrenschmidt
@ 2012-06-03 2:28 ` Stephen Rothwell
2012-06-03 3:48 ` Anton Blanchard
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2012-06-03 2:28 UTC (permalink / raw)
To: Anton Blanchard; +Cc: michael, linuxppc-dev, paulus, viro
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
Hi Anton,
On Sat, 2 Jun 2012 21:34:52 +1000 Anton Blanchard <anton@samba.org> wrote:
>
> commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to
> explicitly-sized type) changed the size of st_nlink on ppc64 from
> a long to a short, resulting in boot failures.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Would this affect my (early user mode) boot problems reported yesterday;
/init: 71: mknod: Permission denied
/init: 88: mknod: Permission denied
/init: 88: mknod: Permission denied
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: Fix size of st_nlink on 64bit
2012-06-03 2:28 ` Stephen Rothwell
@ 2012-06-03 3:48 ` Anton Blanchard
2012-06-03 5:30 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Anton Blanchard @ 2012-06-03 3:48 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: michael, linuxppc-dev, paulus, viro
Hi Stephen,
> > commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to
> > explicitly-sized type) changed the size of st_nlink on ppc64 from
> > a long to a short, resulting in boot failures.
> >
> > Signed-off-by: Anton Blanchard <anton@samba.org>
>
> Would this affect my (early user mode) boot problems reported
> yesterday;
>
> /init: 71: mknod: Permission denied
> /init: 88: mknod: Permission denied
> /init: 88: mknod: Permission denied
Very similar to the errors I was seeing so I think the patch will fix
it.
Anton
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: Fix size of st_nlink on 64bit
2012-06-03 3:48 ` Anton Blanchard
@ 2012-06-03 5:30 ` Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2012-06-03 5:30 UTC (permalink / raw)
To: Anton Blanchard; +Cc: michael, linuxppc-dev, paulus, viro
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
Hi Anton,
On Sun, 3 Jun 2012 13:48:36 +1000 Anton Blanchard <anton@samba.org> wrote:
>
> > > commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to
> > > explicitly-sized type) changed the size of st_nlink on ppc64 from
> > > a long to a short, resulting in boot failures.
> > >
> > > Signed-off-by: Anton Blanchard <anton@samba.org>
> >
> > Would this affect my (early user mode) boot problems reported
> > yesterday;
> >
> > /init: 71: mknod: Permission denied
> > /init: 88: mknod: Permission denied
> > /init: 88: mknod: Permission denied
>
> Very similar to the errors I was seeing so I think the patch will fix
> it.
Great. One less thing to bisect tomorrow :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-03 5:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-02 11:34 [PATCH] powerpc: Fix size of st_nlink on 64bit Anton Blanchard
2012-06-02 21:19 ` Benjamin Herrenschmidt
2012-06-03 2:28 ` Stephen Rothwell
2012-06-03 3:48 ` Anton Blanchard
2012-06-03 5:30 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).