From: Scott Wood <scottwood@freescale.com>
To: Valentin Longchamp <valentin.longchamp@keymile.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [v2, 2/2] powerpc/mpc85xx: add support for Keymile's kmcoge4 board
Date: Wed, 19 Mar 2014 18:08:13 -0500 [thread overview]
Message-ID: <20140319230813.GA30481@home.buserror.net> (raw)
In-Reply-To: <1392119407-29490-3-git-send-email-valentin.longchamp@keymile.com>
On Tue, Feb 11, 2014 at 12:50:07PM +0100, Valentin Longchamp wrote:
> + reset_cpld@1,0 {
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + reg = <1 0 0x80>;
> + interrupt-parent = <&mpic>;
> + interrupts = <
> + 4 1 0 0
> + 5 1 0 0>;
> + };
> +
> + chassis_mgmt@3,0 {
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + reg = <3 0 0x100>;
> + interrupt-parent = <&mpic>;
> + interrupts = <6 1 0 0>;
> + };
Dashes are preferred to underscores in device trees.
More importantly, these nodes need proper compatibles and bindings. Once
that's done, the name for the nodes should probably be
"board_control@whatever" for both.
-Scott
next prev parent reply other threads:[~2014-03-19 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 11:50 [PATCH v2 0/2] Support of the kmcoge4 board Valentin Longchamp
2014-02-11 11:50 ` [PATCH v2 1/2] devicetree: bindings: add Zarlink to the vendor prefixes Valentin Longchamp
2014-02-11 11:50 ` [PATCH v2 2/2] powerpc/mpc85xx: add support for Keymile's kmcoge4 board Valentin Longchamp
2014-03-19 23:08 ` Scott Wood [this message]
2014-03-20 8:42 ` [v2, " Valentin Longchamp
2014-03-20 21:30 ` [v2,2/2] " Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319230813.GA30481@home.buserror.net \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.longchamp@keymile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).