From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: Scott Wood <scottwood@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [v2, 2/2] powerpc/mpc85xx: add support for Keymile's kmcoge4 board
Date: Thu, 20 Mar 2014 09:42:32 +0100 [thread overview]
Message-ID: <532AA9F8.3060406@keymile.com> (raw)
In-Reply-To: <20140319230813.GA30481@home.buserror.net>
On 03/20/2014 12:08 AM, Scott Wood wrote:
> On Tue, Feb 11, 2014 at 12:50:07PM +0100, Valentin Longchamp wrote:
>> + reset_cpld@1,0 {
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + reg = <1 0 0x80>;
>> + interrupt-parent = <&mpic>;
>> + interrupts = <
>> + 4 1 0 0
>> + 5 1 0 0>;
>> + };
>> +
>> + chassis_mgmt@3,0 {
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + reg = <3 0 0x100>;
>> + interrupt-parent = <&mpic>;
>> + interrupts = <6 1 0 0>;
>> + };
>
> Dashes are preferred to underscores in device trees.
OK.
>
> More importantly, these nodes need proper compatibles and bindings. Once
> that's done, the name for the nodes should probably be
> "board_control@whatever" for both.
>
The first one can be board-ctrl. The second however manages things that are
beyond this board and important for other boards in the chassis, so I think
chassis-mgmt is correct.
For the binding/compatbiles issues: in the first discussion I had omitted these
nodes because these are not available (and honestly for such FPGAs I doubt they
will ever be mainlined). We discussed it and concluded that the DTS should
describe the HW and not the drivers available in the kernel so I have now added
them. Do you want me to add the compatible strings we use in our tree even
though there are no bindings ? Leave them as is ? Or drop them ?
Valentin
next prev parent reply other threads:[~2014-03-20 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 11:50 [PATCH v2 0/2] Support of the kmcoge4 board Valentin Longchamp
2014-02-11 11:50 ` [PATCH v2 1/2] devicetree: bindings: add Zarlink to the vendor prefixes Valentin Longchamp
2014-02-11 11:50 ` [PATCH v2 2/2] powerpc/mpc85xx: add support for Keymile's kmcoge4 board Valentin Longchamp
2014-03-19 23:08 ` [v2, " Scott Wood
2014-03-20 8:42 ` Valentin Longchamp [this message]
2014-03-20 21:30 ` [v2,2/2] " Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AA9F8.3060406@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).