* [PATCH 04/24] powerpc: check/return actual error on sysfs functions
@ 2014-06-17 14:31 Jeff Liu
2014-06-17 19:23 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Liu @ 2014-06-17 14:31 UTC (permalink / raw)
To: benh, paulus; +Cc: linuxppc-dev, LKML
From: Jie Liu <jeff.liu@oracle.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c
index 788a197..e718baf 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c
@@ -424,7 +424,7 @@ void __init opal_platform_dump_init(void)
int rc;
dump_kset = kset_create_and_add("dump", NULL, opal_kobj);
- if (!dump_kset) {
+ if (IS_ERR(dump_kset)) {
pr_warn("%s: Failed to create dump kset\n", __func__);
return;
}
diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index 10268c4..09c1f6f 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -296,9 +296,9 @@ int __init opal_elog_init(void)
int rc = 0;
elog_kset = kset_create_and_add("elog", NULL, opal_kobj);
- if (!elog_kset) {
+ if (IS_ERR(elog_kset)) {
pr_warn("%s: failed to create elog kset\n", __func__);
- return -1;
+ return PTR_ERR(elog_kset);
}
rc = opal_notifier_register(&elog_nb);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/24] powerpc: check/return actual error on sysfs functions
2014-06-17 14:31 [PATCH 04/24] powerpc: check/return actual error on sysfs functions Jeff Liu
@ 2014-06-17 19:23 ` Greg KH
2014-06-24 2:34 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-06-17 19:23 UTC (permalink / raw)
To: Jeff Liu; +Cc: paulus, linuxppc-dev, LKML
On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
> arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
> arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Ben and Paul, please do not take this patch, it is incorrect.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/24] powerpc: check/return actual error on sysfs functions
2014-06-17 19:23 ` Greg KH
@ 2014-06-24 2:34 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2014-06-24 2:34 UTC (permalink / raw)
To: Greg KH; +Cc: Jeff Liu, paulus, linuxppc-dev, LKML
On Tue, 2014-06-17 at 12:23 -0700, Greg KH wrote:
> On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu@oracle.com>
> >
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> > ---
> > arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
> > arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Ben and Paul, please do not take this patch, it is incorrect.
Thanks, ignored :-)
Cheers,
Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-24 2:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-17 14:31 [PATCH 04/24] powerpc: check/return actual error on sysfs functions Jeff Liu
2014-06-17 19:23 ` Greg KH
2014-06-24 2:34 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).