linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [patch -next] ASoC: fsl_asrc: fix an error code in fsl_asrc_probe()
@ 2014-07-31  9:32 Dan Carpenter
  2014-07-31 19:24 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-07-31  9:32 UTC (permalink / raw)
  To: Timur Tabi
  Cc: alsa-devel, Takashi Iwai, kernel-janitors, Liam Girdwood,
	Rob Herring, Jaroslav Kysela, Mark Brown, Grant Likely,
	linuxppc-dev

There is a cut and paste bug so it returns success instead of the error
code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index b9a2888..b04438c 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c
@@ -826,7 +826,7 @@ static int fsl_asrc_probe(struct platform_device *pdev)
 	asrc_priv->mem_clk = devm_clk_get(&pdev->dev, "mem");
 	if (IS_ERR(asrc_priv->mem_clk)) {
 		dev_err(&pdev->dev, "failed to get mem clock\n");
-		return PTR_ERR(asrc_priv->ipg_clk);
+		return PTR_ERR(asrc_priv->mem_clk);
 	}
 
 	asrc_priv->ipg_clk = devm_clk_get(&pdev->dev, "ipg");

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch -next] ASoC: fsl_asrc: fix an error code in fsl_asrc_probe()
  2014-07-31  9:32 [patch -next] ASoC: fsl_asrc: fix an error code in fsl_asrc_probe() Dan Carpenter
@ 2014-07-31 19:24 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-07-31 19:24 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: alsa-devel, Liam Girdwood, Takashi Iwai, kernel-janitors,
	Timur Tabi, Jaroslav Kysela, Rob Herring, Grant Likely,
	linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

On Thu, Jul 31, 2014 at 12:32:09PM +0300, Dan Carpenter wrote:
> There is a cut and paste bug so it returns success instead of the error
> code.

Applied, thanks.  Might be worth looking at how you're generating your
CC lists here, it seems a bit random.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-31 19:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-31  9:32 [patch -next] ASoC: fsl_asrc: fix an error code in fsl_asrc_probe() Dan Carpenter
2014-07-31 19:24 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).