linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools/perf/powerpc: Fix build break
@ 2014-08-14  8:18 Aneesh Kumar K.V
  2014-08-18 23:25 ` Sukadev Bhattiprolu
  2014-10-08 10:14 ` Aneesh Kumar K.V
  0 siblings, 2 replies; 4+ messages in thread
From: Aneesh Kumar K.V @ 2014-08-14  8:18 UTC (permalink / raw)
  To: benh, paulus, mpe, linux-kernel; +Cc: linuxppc-dev, Aneesh Kumar K.V

  CC       arch/powerpc/util/skip-callchain-idx.o
arch/powerpc/util/skip-callchain-idx.c: In function ‘check_return_reg’:
arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration of function ‘pr_debug’ [-Werror=implicit-function-declaration]
   pr_debug("dwarf_frame_register() %s\n", dwarf_errmsg(-1));

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
index a7c23a4b3778..d73ef8bb08c7 100644
--- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
+++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
@@ -15,6 +15,7 @@
 
 #include "util/thread.h"
 #include "util/callchain.h"
+#include "util/debug.h"
 
 /*
  * When saving the callchain on Power, the kernel conservatively saves
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/perf/powerpc: Fix build break
  2014-08-14  8:18 [PATCH] tools/perf/powerpc: Fix build break Aneesh Kumar K.V
@ 2014-08-18 23:25 ` Sukadev Bhattiprolu
  2014-10-08 10:14 ` Aneesh Kumar K.V
  1 sibling, 0 replies; 4+ messages in thread
From: Sukadev Bhattiprolu @ 2014-08-18 23:25 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: linuxppc-dev, paulus, linux-kernel

I posted a patch for this to LKML last week:

	https://lkml.org/lkml/2014/8/7/77

Aneesh Kumar K.V [aneesh.kumar@linux.vnet.ibm.com] wrote:
|   CC       arch/powerpc/util/skip-callchain-idx.o
| arch/powerpc/util/skip-callchain-idx.c: In function =E2=80=98check_return=
_reg=E2=80=99:
| arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration =
of function =E2=80=98pr_debug=E2=80=99 [-Werror=3Dimplicit-function-declara=
tion]
|    pr_debug("dwarf_frame_register() %s\n", dwarf_errmsg(-1));
|=20
| Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
| ---
|  tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
|  1 file changed, 1 insertion(+)
|=20
| diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/pe=
rf/arch/powerpc/util/skip-callchain-idx.c
| index a7c23a4b3778..d73ef8bb08c7 100644
| --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| @@ -15,6 +15,7 @@
| =20
|  #include "util/thread.h"
|  #include "util/callchain.h"
| +#include "util/debug.h"
| =20
|  /*
|   * When saving the callchain on Power, the kernel conservatively saves
| --=20
| 1.9.1
|=20
| _______________________________________________
| Linuxppc-dev mailing list
| Linuxppc-dev@lists.ozlabs.org
| https://lists.ozlabs.org/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/perf/powerpc: Fix build break
  2014-08-14  8:18 [PATCH] tools/perf/powerpc: Fix build break Aneesh Kumar K.V
  2014-08-18 23:25 ` Sukadev Bhattiprolu
@ 2014-10-08 10:14 ` Aneesh Kumar K.V
  2014-10-08 18:01   ` Sukadev Bhattiprolu
  1 sibling, 1 reply; 4+ messages in thread
From: Aneesh Kumar K.V @ 2014-10-08 10:14 UTC (permalink / raw)
  To: benh, paulus, mpe, linux-kernel; +Cc: linuxppc-dev

"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes:

>   CC       arch/powerpc/util/skip-callchain-idx.o
> arch/powerpc/util/skip-callchain-idx.c: In function =E2=80=98check_return=
_reg=E2=80=99:
> arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration =
of function =E2=80=98pr_debug=E2=80=99 [-Werror=3Dimplicit-function-declara=
tion]
>    pr_debug("dwarf_frame_register() %s\n", dwarf_errmsg(-1));
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/pe=
rf/arch/powerpc/util/skip-callchain-idx.c
> index a7c23a4b3778..d73ef8bb08c7 100644
> --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
> +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
> @@ -15,6 +15,7 @@
>
>  #include "util/thread.h"
>  #include "util/callchain.h"
> +#include "util/debug.h"
>
>  /*
>   * When saving the callchain on Power, the kernel conservatively saves

We still have this broken upstream.

-aneesh

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/perf/powerpc: Fix build break
  2014-10-08 10:14 ` Aneesh Kumar K.V
@ 2014-10-08 18:01   ` Sukadev Bhattiprolu
  0 siblings, 0 replies; 4+ messages in thread
From: Sukadev Bhattiprolu @ 2014-10-08 18:01 UTC (permalink / raw)
  To: Aneesh Kumar K.V
  Cc: Arnaldo Carvalho de Melo, paulus, linux-kernel, linuxppc-dev, mingo

Aneesh Kumar K.V [aneesh.kumar@linux.vnet.ibm.com] wrote:
| "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes:
|=20
| >   CC       arch/powerpc/util/skip-callchain-idx.o
| > arch/powerpc/util/skip-callchain-idx.c: In function =E2=80=98check_retu=
rn_reg=E2=80=99:
| > arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaratio=
n of function =E2=80=98pr_debug=E2=80=99 [-Werror=3Dimplicit-function-decla=
ration]
| >    pr_debug("dwarf_frame_register() %s\n", dwarf_errmsg(-1));
| >
| > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
| > ---
| >  tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
| >  1 file changed, 1 insertion(+)
| >
| > diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/=
perf/arch/powerpc/util/skip-callchain-idx.c
| > index a7c23a4b3778..d73ef8bb08c7 100644
| > --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| > +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| > @@ -15,6 +15,7 @@
| >
| >  #include "util/thread.h"
| >  #include "util/callchain.h"
| > +#include "util/debug.h"
| >
| >  /*
| >   * When saving the callchain on Power, the kernel conservatively saves
|=20
| We still have this broken upstream.

The fix is in Ingo's tree, commit ad7e767.

Ingo, can you push this fix to Linus - it fixes a build failure in
Powerpc.

Sukadev


|=20
| -aneesh
|=20
| _______________________________________________
| Linuxppc-dev mailing list
| Linuxppc-dev@lists.ozlabs.org
| https://lists.ozlabs.org/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-08 18:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-14  8:18 [PATCH] tools/perf/powerpc: Fix build break Aneesh Kumar K.V
2014-08-18 23:25 ` Sukadev Bhattiprolu
2014-10-08 10:14 ` Aneesh Kumar K.V
2014-10-08 18:01   ` Sukadev Bhattiprolu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).