* [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability
@ 2014-09-19 9:25 Wei Yang
2014-09-19 10:18 ` Gavin Shan
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yang @ 2014-09-19 9:25 UTC (permalink / raw)
To: benh, linuxppc-dev, gwshan; +Cc: Wei Yang
pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
it again.
This patch removes it.
Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
arch/powerpc/kernel/pci-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index b2814e2..9cfa069 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8)
EARLY_PCI_OP(write, word, u16)
EARLY_PCI_OP(write, dword, u32)
-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
int early_find_capability(struct pci_controller *hose, int bus, int devfn,
int cap)
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability
2014-09-19 9:25 [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability Wei Yang
@ 2014-09-19 10:18 ` Gavin Shan
2014-10-14 6:25 ` Wei Yang
0 siblings, 1 reply; 4+ messages in thread
From: Gavin Shan @ 2014-09-19 10:18 UTC (permalink / raw)
To: Wei Yang; +Cc: linuxppc-dev, gwshan
On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote:
>pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
>it again.
>
>This patch removes it.
>
>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Thanks,
Gavin
>---
> arch/powerpc/kernel/pci-common.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>index b2814e2..9cfa069 100644
>--- a/arch/powerpc/kernel/pci-common.c
>+++ b/arch/powerpc/kernel/pci-common.c
>@@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8)
> EARLY_PCI_OP(write, word, u16)
> EARLY_PCI_OP(write, dword, u32)
>
>-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
> int early_find_capability(struct pci_controller *hose, int bus, int devfn,
> int cap)
> {
>--
>1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability
2014-09-19 10:18 ` Gavin Shan
@ 2014-10-14 6:25 ` Wei Yang
2014-10-14 6:41 ` Wei Yang
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yang @ 2014-10-14 6:25 UTC (permalink / raw)
To: michaele; +Cc: Wei Yang, linuxppc-dev, Gavin Shan
On Fri, Sep 19, 2014 at 08:18:02PM +1000, Gavin Shan wrote:
>On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote:
>>pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
>>it again.
>>
>>This patch removes it.
>>
>>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>
>Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>
>Thanks,
>Gavin
Hi, Michael
I see this is not merged in your tree. Do you have some comment?
>
>>---
>> arch/powerpc/kernel/pci-common.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>>diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>>index b2814e2..9cfa069 100644
>>--- a/arch/powerpc/kernel/pci-common.c
>>+++ b/arch/powerpc/kernel/pci-common.c
>>@@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8)
>> EARLY_PCI_OP(write, word, u16)
>> EARLY_PCI_OP(write, dword, u32)
>>
>>-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
>> int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>> int cap)
>> {
>>--
>>1.7.9.5
>>
--
Richard Yang
Help you, Help me
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability
2014-10-14 6:25 ` Wei Yang
@ 2014-10-14 6:41 ` Wei Yang
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yang @ 2014-10-14 6:41 UTC (permalink / raw)
To: michaele; +Cc: linuxppc-dev, Gavin Shan
On Tue, Oct 14, 2014 at 02:25:39PM +0800, Wei Yang wrote:
>On Fri, Sep 19, 2014 at 08:18:02PM +1000, Gavin Shan wrote:
>>On Fri, Sep 19, 2014 at 05:25:22PM +0800, Wei Yang wrote:
>>>pci_bus_find_capability() is decleared in pci.h, so it is not necessary to do
>>>it again.
>>>
>>>This patch removes it.
>>>
>>>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>>
>>Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>>
>>Thanks,
>>Gavin
>
>Hi, Michael
>
>I see this is not merged in your tree. Do you have some comment?
>
Oops,
As pointed by Gavin, it is in the next branch.
>>
>>>---
>>> arch/powerpc/kernel/pci-common.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>>diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>>>index b2814e2..9cfa069 100644
>>>--- a/arch/powerpc/kernel/pci-common.c
>>>+++ b/arch/powerpc/kernel/pci-common.c
>>>@@ -1561,7 +1561,6 @@ EARLY_PCI_OP(write, byte, u8)
>>> EARLY_PCI_OP(write, word, u16)
>>> EARLY_PCI_OP(write, dword, u32)
>>>
>>>-extern int pci_bus_find_capability (struct pci_bus *bus, unsigned int devfn, int cap);
>>> int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>>> int cap)
>>> {
>>>--
>>>1.7.9.5
>>>
>
>--
>Richard Yang
>Help you, Help me
--
Richard Yang
Help you, Help me
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-14 6:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-19 9:25 [PATCH] powerpc/pci: remove duplicate declaration of pci_bus_find_capability Wei Yang
2014-09-19 10:18 ` Gavin Shan
2014-10-14 6:25 ` Wei Yang
2014-10-14 6:41 ` Wei Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).