* [PATCH] powerpc/perf/24x7: Fix lockdep warning
@ 2015-07-07 19:37 Sukadev Bhattiprolu
2015-07-07 20:54 ` Gustavo Luiz Duarte
2015-07-08 10:54 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2015-07-07 19:37 UTC (permalink / raw)
To: Michael Ellerman; +Cc: gustavold, linux-kernel, linuxppc-dev
>From 370152d9427e57cd9632b00189f71099f8e85544 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Date: Tue, 7 Jul 2015 12:21:10 -0400
Subject: [PATCH 1/1] powerpc/perf/24x7: Fix lockdep warning
The sysfs attributes for the 24x7 counters are dynamically allocated.
Initialize the attributes using sysfs_attr_init() to fix following
warning which occurs when CONFIG_DEBUG_LOCK_VMALLOC=y.
[ 0.346249] audit: initializing netlink subsys (disabled)
[ 0.346284] audit: type=2000 audit(1436295254.340:1): initialized
[ 0.346489] BUG: key c0000000efe90198 not in .data!
[ 0.346491] DEBUG_LOCKS_WARN_ON(1)
[ 0.346502] ------------[ cut here ]------------
[ 0.346504] WARNING: at ../kernel/locking/lockdep.c:3002
[ 0.346506] Modules linked in:
Reported-by: Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
arch/powerpc/perf/hv-24x7.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index ec2eb20..df95629 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c
@@ -320,6 +320,8 @@ static struct attribute *device_str_attr_create_(char *name, char *str)
if (!attr)
return NULL;
+ sysfs_attr_init(&attr->attr.attr);
+
attr->var = str;
attr->attr.attr.name = name;
attr->attr.attr.mode = 0444;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/perf/24x7: Fix lockdep warning
2015-07-07 19:37 [PATCH] powerpc/perf/24x7: Fix lockdep warning Sukadev Bhattiprolu
@ 2015-07-07 20:54 ` Gustavo Luiz Duarte
2015-07-08 10:54 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Luiz Duarte @ 2015-07-07 20:54 UTC (permalink / raw)
To: Sukadev Bhattiprolu; +Cc: linux-kernel, linuxppc-dev, Michael Ellerman
On 07/07/2015 04:37 PM, Sukadev Bhattiprolu wrote:
> From 370152d9427e57cd9632b00189f71099f8e85544 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Tue, 7 Jul 2015 12:21:10 -0400
> Subject: [PATCH 1/1] powerpc/perf/24x7: Fix lockdep warning
>
> The sysfs attributes for the 24x7 counters are dynamically allocated.
> Initialize the attributes using sysfs_attr_init() to fix following
> warning which occurs when CONFIG_DEBUG_LOCK_VMALLOC=y.
>
> [ 0.346249] audit: initializing netlink subsys (disabled)
> [ 0.346284] audit: type=2000 audit(1436295254.340:1): initialized
> [ 0.346489] BUG: key c0000000efe90198 not in .data!
> [ 0.346491] DEBUG_LOCKS_WARN_ON(1)
> [ 0.346502] ------------[ cut here ]------------
> [ 0.346504] WARNING: at ../kernel/locking/lockdep.c:3002
> [ 0.346506] Modules linked in:
>
> Reported-by: Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Tested-by: Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
I verified that it fixes a BUG splat on PowerVM (tested on little endian).
[]'s
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc/perf/24x7: Fix lockdep warning
2015-07-07 19:37 [PATCH] powerpc/perf/24x7: Fix lockdep warning Sukadev Bhattiprolu
2015-07-07 20:54 ` Gustavo Luiz Duarte
@ 2015-07-08 10:54 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2015-07-08 10:54 UTC (permalink / raw)
To: Sukadev Bhattiprolu; +Cc: linuxppc-dev, linux-kernel, gustavold
On Tue, 2015-07-07 at 19:37:25 UTC, Sukadev Bhattiprolu wrote:
> >From 370152d9427e57cd9632b00189f71099f8e85544 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Tue, 7 Jul 2015 12:21:10 -0400
> Subject: [PATCH 1/1] powerpc/perf/24x7: Fix lockdep warning
>
> The sysfs attributes for the 24x7 counters are dynamically allocated.
> Initialize the attributes using sysfs_attr_init() to fix following
> warning which occurs when CONFIG_DEBUG_LOCK_VMALLOC=y.
>
> [ 0.346249] audit: initializing netlink subsys (disabled)
> [ 0.346284] audit: type=2000 audit(1436295254.340:1): initialized
> [ 0.346489] BUG: key c0000000efe90198 not in .data!
> [ 0.346491] DEBUG_LOCKS_WARN_ON(1)
> [ 0.346502] ------------[ cut here ]------------
> [ 0.346504] WARNING: at ../kernel/locking/lockdep.c:3002
> [ 0.346506] Modules linked in:
>
> Reported-by: Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Tested-by: Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=442053e57a4fc58b719b6ceab60f29ef9cf4404c
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-07 19:37 [PATCH] powerpc/perf/24x7: Fix lockdep warning Sukadev Bhattiprolu
2015-07-07 20:54 ` Gustavo Luiz Duarte
2015-07-08 10:54 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).