* [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH
@ 2015-09-29 10:35 Michael Ellerman
2015-09-30 15:03 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2015-09-29 10:35 UTC (permalink / raw)
To: linuxppc-dev; +Cc: hch, JBottomley, snitzer, hare, martin.petersen
Commit 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
changed CONFIG_SCSI_DH from tristate to bool.
Our defconfigs have CONFIG_SCSI_DH=m, which the kconfig machinery warns
us is invalid, but instead of converting it to =y it leaves it unset.
This means we loose the CONFIG_SCSI_DH code and everything that depends
on it.
So convert the values in the defconfigs to =y.
Fixes: 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/configs/ppc64_defconfig | 2 +-
arch/powerpc/configs/pseries_defconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig
index 6bc0ee4b1070..2c041b535a64 100644
--- a/arch/powerpc/configs/ppc64_defconfig
+++ b/arch/powerpc/configs/ppc64_defconfig
@@ -111,7 +111,7 @@ CONFIG_SCSI_QLA_FC=m
CONFIG_SCSI_QLA_ISCSI=m
CONFIG_SCSI_LPFC=m
CONFIG_SCSI_VIRTIO=m
-CONFIG_SCSI_DH=m
+CONFIG_SCSI_DH=y
CONFIG_SCSI_DH_RDAC=m
CONFIG_SCSI_DH_ALUA=m
CONFIG_ATA=y
diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index 7991f37e5fe2..36871a4bfa54 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -114,7 +114,7 @@ CONFIG_SCSI_QLA_FC=m
CONFIG_SCSI_QLA_ISCSI=m
CONFIG_SCSI_LPFC=m
CONFIG_SCSI_VIRTIO=m
-CONFIG_SCSI_DH=m
+CONFIG_SCSI_DH=y
CONFIG_SCSI_DH_RDAC=m
CONFIG_SCSI_DH_ALUA=m
CONFIG_ATA=y
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH
2015-09-29 10:35 [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH Michael Ellerman
@ 2015-09-30 15:03 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2015-09-30 15:03 UTC (permalink / raw)
To: Michael Ellerman
Cc: linuxppc-dev, hch, JBottomley, snitzer, hare, martin.petersen
On Tue, Sep 29, 2015 at 08:35:08PM +1000, Michael Ellerman wrote:
> Commit 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
> changed CONFIG_SCSI_DH from tristate to bool.
>
> Our defconfigs have CONFIG_SCSI_DH=m, which the kconfig machinery warns
> us is invalid, but instead of converting it to =y it leaves it unset.
> This means we loose the CONFIG_SCSI_DH code and everything that depends
> on it.
>
> So convert the values in the defconfigs to =y.
>
> Fixes: 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-30 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-29 10:35 [PATCH] powerpc/configs: Re-enable CONFIG_SCSI_DH Michael Ellerman
2015-09-30 15:03 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).