linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	<linuxppc-dev@lists.ozlabs.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Neuling <mikey@neuling.org>
Subject: linux-next: build failure after merge of the powerpc tree
Date: Thu, 7 Jan 2016 19:16:13 +1100	[thread overview]
Message-ID: <20160107191613.0228560b@canb.auug.org.au> (raw)

Hi all,

After merging the powerpc tree, today's linux-next build (powerpc64
allnoconfig) failed like this:

arch/powerpc/mm/hash_utils_64.c: In function 'get_paca_psize':
arch/powerpc/mm/hash_utils_64.c:869:19: error: 'struct paca_struct' has no member named 'context'
  return get_paca()->context.user_psize;
                   ^
arch/powerpc/mm/hash_utils_64.c:870:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Caused by commit

  2fc251a8dda5 ("powerpc: Copy only required pieces of the mm_context_t to the paca")

This build has CONFIG_PPC_MM_SLICES not set ...

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 7 Jan 2016 19:07:18 +1100
Subject: [PATCH] powerpc: restore the user_psize member of the mm_context_t in
 the paca

It is used when CONFIG_PPC_MM_SLICES is not set.

Fixes: 2fc251a8dda5 ("powerpc: Copy only required pieces of the mm_context_t to the paca")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/include/asm/paca.h | 2 ++
 arch/powerpc/mm/hash_utils_64.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/paca.h b/arch/powerpc/include/asm/paca.h
index ef78c288c712..546540b91095 100644
--- a/arch/powerpc/include/asm/paca.h
+++ b/arch/powerpc/include/asm/paca.h
@@ -138,6 +138,7 @@ struct paca_struct {
 	u64 mm_ctx_low_slices_psize;
 	unsigned char mm_ctx_high_slices_psize[SLICE_ARRAY_SIZE];
 #else
+	u16 mm_ctx_user_psize;
 	u16 mm_ctx_sllp;
 #endif
 #endif
@@ -212,6 +213,7 @@ static inline void copy_mm_to_paca(mm_context_t *context)
 	memcpy(&get_paca()->mm_ctx_high_slices_psize,
 	       &context->high_slices_psize, SLICE_ARRAY_SIZE);
 #else
+	get_paca()->mm_ctx_user_psize = context->user_psize;
 	get_paca()->mm_ctx_sllp = context->sllp;
 #endif
 }
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index db744576d730..ba59d5977f34 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -866,7 +866,7 @@ static unsigned int get_paca_psize(unsigned long addr)
 #else
 unsigned int get_paca_psize(unsigned long addr)
 {
-	return get_paca()->context.user_psize;
+	return get_paca()->mm_ctx_user_psize;
 }
 #endif
 
-- 
2.6.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

             reply	other threads:[~2016-01-07  8:16 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07  8:16 Stephen Rothwell [this message]
2016-01-07 10:30 ` linux-next: build failure after merge of the powerpc tree Michael Ellerman
2016-01-13  5:46   ` Aneesh Kumar K.V
2016-01-13  7:44     ` Michael Ellerman
2016-01-12 12:32 ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2023-02-10  3:38 Stephen Rothwell
2023-02-12 23:22 ` Michael Ellerman
2021-04-19  9:14 Stephen Rothwell
2021-04-19  9:59 ` Xiongwei Song
2021-04-19 12:24   ` Michael Ellerman
2021-02-09 10:19 Stephen Rothwell
2021-02-10  8:20 ` Nicholas Piggin
2021-02-10 11:18   ` Stephen Rothwell
2020-04-22  5:41 Stephen Rothwell
2020-04-22  6:35 ` Haren Myneni
2020-04-25 23:52 ` Michael Ellerman
2019-09-30  0:13 Stephen Rothwell
2019-10-03 23:05 ` Michael Ellerman
2019-10-11  8:22 ` Michael Ellerman
2019-09-02 11:40 Stephen Rothwell
2019-09-02 11:52 ` Christoph Hellwig
2019-02-22  7:14 Stephen Rothwell
2019-02-22  7:37 ` Christophe Leroy
2019-02-22 11:28   ` Michael Ellerman
2018-03-29  7:43 Stephen Rothwell
2018-01-19  5:53 Stephen Rothwell
2018-01-18 22:26 Stephen Rothwell
2017-11-02  6:49 Stephen Rothwell
2017-11-14 11:12 ` Michael Ellerman
2016-11-22  8:58 Stephen Rothwell
2016-11-22 10:21 ` Stephen Rothwell
2016-11-23  2:02   ` Nicholas Piggin
2016-07-22  6:31 Stephen Rothwell
2016-07-01  5:27 Stephen Rothwell
2016-07-01  8:59 ` Colin Ian King
2015-08-21  8:25 Stephen Rothwell
2015-08-21  8:59 ` Vasant Hegde
2015-08-21 23:40   ` Michael Ellerman
2015-08-22  4:09     ` Vasant Hegde
2015-08-22 11:16       ` Michael Ellerman
2014-08-06  6:31 Stephen Rothwell
2013-07-02  0:54 Stephen Rothwell
2013-07-02  2:00 ` Benjamin Herrenschmidt
2012-11-28  3:03 Stephen Rothwell
2012-11-28  4:28 ` Benjamin Herrenschmidt
2011-07-01  1:39 Stephen Rothwell
2011-07-01  3:00 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160107191613.0228560b@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).