* [PATCH 0867/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:53 Baole Ni
2016-08-02 16:45 ` Geoff Levand
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 11:53 UTC (permalink / raw)
To: geoff, benh, paulus, mpe, dwmw2, m.chehab, pawel, m.szyprowski,
kyungmin.park, k.kozlowski
Cc: linuxppc-dev, linux-kernel, chuansheng.liu, baolex.ni
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/ps3/ps3av.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
index 437fc35..9753ed0 100644
--- a/drivers/ps3/ps3av.c
+++ b/drivers/ps3/ps3av.c
@@ -38,7 +38,7 @@
static int safe_mode;
static int timeout = 5000; /* in msec ( 5 sec ) */
-module_param(timeout, int, 0644);
+module_param(timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
static struct ps3av {
struct mutex mutex;
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 0867/1285] Replace numeric parameter like 0444 with macro
2016-08-02 11:53 [PATCH 0867/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 16:45 ` Geoff Levand
0 siblings, 0 replies; 2+ messages in thread
From: Geoff Levand @ 2016-08-02 16:45 UTC (permalink / raw)
To: Baole Ni, benh, paulus, mpe, dwmw2, m.chehab, pawel,
m.szyprowski, kyungmin.park, k.kozlowski
Cc: linuxppc-dev, linux-kernel, chuansheng.liu
On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access
> permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of
> the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>
> static int timeout = 5000; /* in msec ( 5 sec ) */
> -module_param(timeout, int, 0644);
> +module_param(timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
To me, 644 is more 'readable', and as for robustness, the meaning of
644 will never change.
-Geoff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:53 [PATCH 0867/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 16:45 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).