* Re: [PATCH v2 2/4] asm-generic/io.h: Remove unused generic __ioremap() definition
[not found] ` <20170320184253.4858.12956.stgit@bhelgaas-glaptop.roam.corp.google.com>
@ 2017-03-21 10:37 ` Geert Uytterhoeven
2017-03-21 19:59 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-03-21 10:37 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Arnd Bergmann, Michael Ellerman, Linux-Arch, linux-pci,
Luis R. Rodriguez, linux-kernel, linuxppc-dev
Hi Bj=C3=B6rn,
On Mon, Mar 20, 2017 at 7:42 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> Several arches use __ioremap() to help implement the generic ioremap(),
> ioremap_nocache(), and ioremap_wc() interfaces, but this usage is all
> inside the arch/ directory.
>
> The only __ioremap() uses outside arch/ are in the ZorroII RAM disk drive=
r
> and some framebuffer drivers that are only buildable on m68k and powerpc,
> and they use the versions provided by those arches.
>
> There's no need for a generic version of __ioremap(), so remove it.
These all predate the ioremap_*() variants, and can be converted to
either ioremap_nocache() or ioremap_wt().
However, PPC doesn't implement ioremap_wt() yet, so asm-generic will
fall back to the less-efficient nocache variant.
PPC does support __ioremap(..., _PAGE_WRITETHRU), so adding a wrapper
is trivial.
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Regardless,
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org
In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/4] asm-generic/io.h: Remove unused generic __ioremap() definition
2017-03-21 10:37 ` [PATCH v2 2/4] asm-generic/io.h: Remove unused generic __ioremap() definition Geert Uytterhoeven
@ 2017-03-21 19:59 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2017-03-21 19:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bjorn Helgaas, Arnd Bergmann, Michael Ellerman, Linux-Arch,
linux-pci, Luis R. Rodriguez, linux-kernel, linuxppc-dev
On Tue, Mar 21, 2017 at 11:37:11AM +0100, Geert Uytterhoeven wrote:
> Hi Björn,
>
> On Mon, Mar 20, 2017 at 7:42 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > Several arches use __ioremap() to help implement the generic ioremap(),
> > ioremap_nocache(), and ioremap_wc() interfaces, but this usage is all
> > inside the arch/ directory.
> >
> > The only __ioremap() uses outside arch/ are in the ZorroII RAM disk driver
> > and some framebuffer drivers that are only buildable on m68k and powerpc,
> > and they use the versions provided by those arches.
> >
> > There's no need for a generic version of __ioremap(), so remove it.
>
> These all predate the ioremap_*() variants, and can be converted to
> either ioremap_nocache() or ioremap_wt().
>
> However, PPC doesn't implement ioremap_wt() yet, so asm-generic will
> fall back to the less-efficient nocache variant.
> PPC does support __ioremap(..., _PAGE_WRITETHRU), so adding a wrapper
> is trivial.
Thanks, I'll try adding ioremap_wt() (at least for PPC32) and cleaning this
up.
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> Regardless,
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-21 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170320182014.4858.22352.stgit@bhelgaas-glaptop.roam.corp.google.com>
[not found] ` <20170320184253.4858.12956.stgit@bhelgaas-glaptop.roam.corp.google.com>
2017-03-21 10:37 ` [PATCH v2 2/4] asm-generic/io.h: Remove unused generic __ioremap() definition Geert Uytterhoeven
2017-03-21 19:59 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).