* [PATCH v2 0/1] rtc: rtctest: Support opal-rtc and rtc-generic
@ 2017-08-15 8:45 Lukáš Doktor
2017-08-15 8:46 ` [PATCH v2 1/1] rtc: rtctest: Improve support detection Lukáš Doktor
0 siblings, 1 reply; 3+ messages in thread
From: Lukáš Doktor @ 2017-08-15 8:45 UTC (permalink / raw)
To: ldoktor, a.zummo, linuxppc-dev, sboyd, linux-kernel,
alexandre.belloni, linux-kselftest, john.stultz, tglx, shuah,
linux-rtc
On ppc64le machines the opal-rtc, resp rtc-generic in guest is used. They only
support minimal set of functionality and fail this test in not-yet treated
way. This extends the checks and skips to the next test when feature is not
supported.
Changes in v2:
- Removed the double EINVAL check
- Added missing space before "EIO" check.
Lukáš Doktor (1):
rtc: rtctest: Improve support detection
tools/testing/selftests/timers/rtctest.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--
2.9.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] rtc: rtctest: Improve support detection
2017-08-15 8:45 [PATCH v2 0/1] rtc: rtctest: Support opal-rtc and rtc-generic Lukáš Doktor
@ 2017-08-15 8:46 ` Lukáš Doktor
2017-08-16 23:06 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Lukáš Doktor @ 2017-08-15 8:46 UTC (permalink / raw)
To: ldoktor, a.zummo, linuxppc-dev, sboyd, linux-kernel,
alexandre.belloni, linux-kselftest, john.stultz, tglx, shuah,
linux-rtc
The rtc-generic and opal-rtc are failing to run this test as they do not
support all the features. Let's treat the error returns and skip to the
following test.
Theoretically the test_DATE should be also adjusted, but as it's enabled
on demand I think it makes sense to fail in such case.
Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
---
tools/testing/selftests/timers/rtctest.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c
index f61170f..411eff6 100644
--- a/tools/testing/selftests/timers/rtctest.c
+++ b/tools/testing/selftests/timers/rtctest.c
@@ -221,6 +221,11 @@ int main(int argc, char **argv)
/* Read the current alarm settings */
retval = ioctl(fd, RTC_ALM_READ, &rtc_tm);
if (retval == -1) {
+ if (errno == EINVAL) {
+ fprintf(stderr,
+ "\n...EINVAL reading current alarm setting.\n");
+ goto test_PIE;
+ }
perror("RTC_ALM_READ ioctl");
exit(errno);
}
@@ -231,7 +236,7 @@ int main(int argc, char **argv)
/* Enable alarm interrupts */
retval = ioctl(fd, RTC_AIE_ON, 0);
if (retval == -1) {
- if (errno == EINVAL) {
+ if (errno == EINVAL || errno == EIO) {
fprintf(stderr,
"\n...Alarm IRQs not supported.\n");
goto test_PIE;
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] rtc: rtctest: Improve support detection
2017-08-15 8:46 ` [PATCH v2 1/1] rtc: rtctest: Improve support detection Lukáš Doktor
@ 2017-08-16 23:06 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2017-08-16 23:06 UTC (permalink / raw)
To: Lukáš Doktor, a.zummo, linuxppc-dev, sboyd,
linux-kernel, alexandre.belloni, linux-kselftest, john.stultz,
tglx, linux-rtc, Shuah Khan, Shuah Khan
On 08/15/2017 02:46 AM, Lukáš Doktor wrote:
> The rtc-generic and opal-rtc are failing to run this test as they do not
> support all the features. Let's treat the error returns and skip to the
> following test.
>
> Theoretically the test_DATE should be also adjusted, but as it's enabled
> on demand I think it makes sense to fail in such case.
>
> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
> ---
> tools/testing/selftests/timers/rtctest.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c
> index f61170f..411eff6 100644
> --- a/tools/testing/selftests/timers/rtctest.c
> +++ b/tools/testing/selftests/timers/rtctest.c
> @@ -221,6 +221,11 @@ int main(int argc, char **argv)
> /* Read the current alarm settings */
> retval = ioctl(fd, RTC_ALM_READ, &rtc_tm);
> if (retval == -1) {
> + if (errno == EINVAL) {
> + fprintf(stderr,
> + "\n...EINVAL reading current alarm setting.\n");
> + goto test_PIE;
> + }
> perror("RTC_ALM_READ ioctl");
> exit(errno);
> }
> @@ -231,7 +236,7 @@ int main(int argc, char **argv)
> /* Enable alarm interrupts */
> retval = ioctl(fd, RTC_AIE_ON, 0);
> if (retval == -1) {
> - if (errno == EINVAL) {
> + if (errno == EINVAL || errno == EIO) {
> fprintf(stderr,
> "\n...Alarm IRQs not supported.\n");
> goto test_PIE;
>
Applied to linux-kselftest next for 4.14-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-16 23:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 8:45 [PATCH v2 0/1] rtc: rtctest: Support opal-rtc and rtc-generic Lukáš Doktor
2017-08-15 8:46 ` [PATCH v2 1/1] rtc: rtctest: Improve support detection Lukáš Doktor
2017-08-16 23:06 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).