* [PATCH] powerpc/time: stop validating rtc_time in .read_time
@ 2018-02-21 21:46 Alexandre Belloni
2018-03-19 22:22 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2018-02-21 21:46 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-rtc,
linux-kernel, Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
arch/powerpc/kernel/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index a32823dcd9a4..f7d96a68ecaa 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -1234,7 +1234,7 @@ void calibrate_delay(void)
static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
{
ppc_md.get_rtc_time(tm);
- return rtc_valid_tm(tm);
+ return 0;
}
static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc/time: stop validating rtc_time in .read_time
2018-02-21 21:46 [PATCH] powerpc/time: stop validating rtc_time in .read_time Alexandre Belloni
@ 2018-03-19 22:22 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-03-19 22:22 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-rtc, Alexandre Belloni, linux-kernel, Paul Mackerras, linuxppc-dev
On Wed, 2018-02-21 at 21:46:33 UTC, Alexandre Belloni wrote:
> The RTC core is always calling rtc_valid_tm after the read_time callback.
> It is not necessary to call it just before returning from the callback.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/890ae7979758568734881ad0f382c4
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 22:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-21 21:46 [PATCH] powerpc/time: stop validating rtc_time in .read_time Alexandre Belloni
2018-03-19 22:22 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).