linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/powerpc: Skip tm-trap if transactional memory is not enabled
@ 2018-02-26  2:19 Michael Ellerman
  2018-03-05 12:36 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2018-02-26  2:19 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: gromero

Some processor revisions do not support transactional memory, and
additionally kernel support can be disabled. In either case the
tm-trap test should be skipped, otherwise it will fail with a SIGILL.

Fixes: a08082f8e4e1 ("powerpc/selftests: Check endianness on trap in TM")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 tools/testing/selftests/powerpc/tm/tm-trap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/powerpc/tm/tm-trap.c b/tools/testing/selftests/powerpc/tm/tm-trap.c
index 5d92c23ee6cb..179d592f0073 100644
--- a/tools/testing/selftests/powerpc/tm/tm-trap.c
+++ b/tools/testing/selftests/powerpc/tm/tm-trap.c
@@ -255,6 +255,8 @@ int tm_trap_test(void)
 
 	struct sigaction trap_sa;
 
+	SKIP_IF(!have_htm());
+
 	trap_sa.sa_flags = SA_SIGINFO;
 	trap_sa.sa_sigaction = trap_signal_handler;
 	sigaction(SIGTRAP, &trap_sa, NULL);
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: selftests/powerpc: Skip tm-trap if transactional memory is not enabled
  2018-02-26  2:19 [PATCH] selftests/powerpc: Skip tm-trap if transactional memory is not enabled Michael Ellerman
@ 2018-03-05 12:36 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-03-05 12:36 UTC (permalink / raw)
  To: Michael Ellerman, linuxppc-dev; +Cc: gromero

On Mon, 2018-02-26 at 02:19:26 UTC, Michael Ellerman wrote:
> Some processor revisions do not support transactional memory, and
> additionally kernel support can be disabled. In either case the
> tm-trap test should be skipped, otherwise it will fail with a SIGILL.
> 
> Fixes: a08082f8e4e1 ("powerpc/selftests: Check endianness on trap in TM")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Applied to powerpc fixes.

https://git.kernel.org/powerpc/c/192b2e742c06af399e8eecb4a17265

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-05 12:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26  2:19 [PATCH] selftests/powerpc: Skip tm-trap if transactional memory is not enabled Michael Ellerman
2018-03-05 12:36 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).