linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Sebastian Ott <sebott@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-pci@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] PCI/IOV: provide flag to skip VF scanning
Date: Tue, 1 Jan 2019 19:14:54 -0600	[thread overview]
Message-ID: <20190102011453.GA126384@google.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1812211514570.22598@schleppi>

On Fri, Dec 21, 2018 at 03:19:49PM +0100, Sebastian Ott wrote:
> Hello Bjorn,
> 
> On Thu, 20 Dec 2018, Bjorn Helgaas wrote:
> > I think the strategy is fine, but can you restructure the patches
> > like this:
> > 
> >   1) Factor out sriov_add_vfs() and sriov_dev_vfs().  This makes no
> >      functional change at all.
> > 
> >   2) Add dev->no_vf_scan, set it in the s390 pcibios_add_device(), and
> >      test it in sriov_add_vfs(), and sriov_del_vfs().
> > 
> > I think both pieces will be easier to review that way.
> 
> Done. I took the liberty to add Christoph's R-b to the first two patches
> since it's just a split of the patch he gave the R-b to.

Thanks.

It's really way too late to do this, but they're pretty trivial, and
I've been out longer than expected for vacation and illness, so I applied
these to pci/virtualization for v4.21.

Bjorn

  reply	other threads:[~2019-01-02  1:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180912123411.23229-1-sebott@linux.ibm.com>
2018-09-12 13:02 ` [PATCH 0/2] sriov enablement on s390 Bjorn Helgaas
2018-09-12 14:40   ` Benjamin Herrenschmidt
2018-09-13 12:41   ` Sebastian Ott
2018-09-13 12:41     ` [PATCH 1/2] pci: provide add_vfs/del_vfs callbacks Sebastian Ott
2018-09-13 12:41     ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-10-10 12:55   ` [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-10-10 16:26     ` Bjorn Helgaas
2018-12-05 13:45       ` Sebastian Ott
2018-12-12 21:54         ` Bjorn Helgaas
2018-12-13 17:54           ` [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs Sebastian Ott
2018-12-14 13:12             ` Christoph Hellwig
2018-12-13 17:54           ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-12-14 13:12             ` Christoph Hellwig
2018-12-14 13:18               ` Christoph Hellwig
2018-12-17 17:30                 ` Sebastian Ott
2018-12-17 17:35                   ` Christoph Hellwig
2018-12-18 10:16                     ` [PATCH 1/2] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-19  7:52                       ` Christoph Hellwig
2018-12-20 20:07                       ` Bjorn Helgaas
2018-12-21 14:14                         ` [PATCH 1/3] PCI/IOV: factor out sriov_add_vfs Sebastian Ott
2018-12-21 14:14                         ` [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-21 14:14                         ` [PATCH 3/3] s390/pci: " Sebastian Ott
2018-12-21 14:19                         ` [PATCH 1/2] PCI/IOV: provide flag to " Sebastian Ott
2019-01-02  1:14                           ` Bjorn Helgaas [this message]
2018-12-18 10:16                     ` [PATCH 2/2] s390/pci: " Sebastian Ott
2018-12-19  7:52                       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102011453.GA126384@google.com \
    --to=helgaas@kernel.org \
    --cc=arnd@arndb.de \
    --cc=hch@infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sebott@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).