From: Sebastian Ott <sebott@linux.ibm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] sriov enablement on s390
Date: Wed, 5 Dec 2018 14:45:14 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.21.1812051432580.1828@schleppi.aag-de.ibmmobiledemo.com> (raw)
In-Reply-To: <20181010162653.GD5906@bhelgaas-glaptop.roam.corp.google.com>
Hello Bjorn,
On Wed, 10 Oct 2018, Bjorn Helgaas wrote:
> On Wed, Oct 10, 2018 at 02:55:07PM +0200, Sebastian Ott wrote:
> > On Wed, 12 Sep 2018, Bjorn Helgaas wrote:
> > > On Wed, Sep 12, 2018 at 02:34:09PM +0200, Sebastian Ott wrote:
> > > > On s390 we currently handle SRIOV within firmware. Which means
> > > > that the PF is under firmware control and not visible to operating
> > > > systems. SRIOV enablement happens within firmware and VFs are
> > > > passed through to logical partitions.
> > > >
> > > > I'm working on a new mode were the PF is under operating system
> > > > control (including SRIOV enablement). However we still need
> > > > firmware support to access the VFs. The way this is supposed
> > > > to work is that when firmware traps the SRIOV enablement it
> > > > will present machine checks to the logical partition that
> > > > triggered the SRIOV enablement and provide the VFs via hotplug
> > > > events.
> > > >
> > > > The problem I'm faced with is that the VF detection code in
> > > > sriov_enable leads to unusable functions in s390.
> > >
> > > We're moving away from the weak function implementation style. Can
> > > you take a look at Arnd's work here, which uses pci_host_bridge
> > > callbacks instead?
> > >
> > > https://lkml.kernel.org/r/20180817102645.3839621-1-arnd@arndb.de
> >
> > What's the status of Arnd's patches - will they go upstream in the next
> > couple of versions?
>
> I hope so [1]. IIRC Arnd mentioned doing some minor updates, so I'm
> waiting on that.
>
> > What about my patches that I rebased on Arnd's branch
> > will they be considered?
>
> Definitely. From my point of view they're just lined up behind Arnd's
> patches.
>
> [1] https://lore.kernel.org/linux-pci/20181002205903.GD120535@bhelgaas-glaptop.roam.corp.google.com
It appears like these patches are not in-line for the next merge window.
Would it be possible to go with my original patches (using __weak
functions)? (This would also make life easier with regards to backports)
I can post patches to convert this to use function pointers once Arnd's
patches make it to the kernel.
Regards,
Sebastian
next prev parent reply other threads:[~2018-12-05 13:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180912123411.23229-1-sebott@linux.ibm.com>
2018-09-12 13:02 ` [PATCH 0/2] sriov enablement on s390 Bjorn Helgaas
2018-09-12 14:40 ` Benjamin Herrenschmidt
2018-09-13 12:41 ` Sebastian Ott
2018-09-13 12:41 ` [PATCH 1/2] pci: provide add_vfs/del_vfs callbacks Sebastian Ott
2018-09-13 12:41 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-10-10 12:55 ` [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-10-10 16:26 ` Bjorn Helgaas
2018-12-05 13:45 ` Sebastian Ott [this message]
2018-12-12 21:54 ` Bjorn Helgaas
2018-12-13 17:54 ` [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-13 17:54 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:18 ` Christoph Hellwig
2018-12-17 17:30 ` Sebastian Ott
2018-12-17 17:35 ` Christoph Hellwig
2018-12-18 10:16 ` [PATCH 1/2] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
2018-12-20 20:07 ` Bjorn Helgaas
2018-12-21 14:14 ` [PATCH 1/3] PCI/IOV: factor out sriov_add_vfs Sebastian Ott
2018-12-21 14:14 ` [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-21 14:14 ` [PATCH 3/3] s390/pci: " Sebastian Ott
2018-12-21 14:19 ` [PATCH 1/2] PCI/IOV: provide flag to " Sebastian Ott
2019-01-02 1:14 ` Bjorn Helgaas
2018-12-18 10:16 ` [PATCH 2/2] s390/pci: " Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1812051432580.1828@schleppi.aag-de.ibmmobiledemo.com \
--to=sebott@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).