From: Michal Hocko <mhocko@kernel.org>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Pingfan Liu <kernelfans@gmail.com>,
linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH] x86, numa: always initialize all possible nodes
Date: Fri, 25 Jan 2019 11:40:23 +0100 [thread overview]
Message-ID: <20190125104023.GI3560@dhcp22.suse.cz> (raw)
In-Reply-To: <20190124175144.GF13790@rapoport-lnx>
On Thu 24-01-19 19:51:44, Mike Rapoport wrote:
> On Thu, Jan 24, 2019 at 03:17:27PM +0100, Michal Hocko wrote:
> > a friendly ping for this. Does anybody see any problem with this
> > approach?
>
> FWIW, it looks fine to me.
>
> It'd just be nice to have a few more words in the changelog about *how* the
> x86 init was reworked ;-)
Heh, I thought it was there but nope... It probably just existed in my
head. Sorry about that. What about the following paragraphs added?
"
The new code relies on the arch specific initialization to allocate all
possible NUMA nodes (including memory less) - numa_register_memblks in
this case. Generic code then initializes both zonelists (__build_all_zonelists)
and allocator internals (free_area_init_nodes) for all non-null pgdats
rather than online ones.
For the x86 specific part also do not make new node online in alloc_node_data
because this is too early to know that. numa_register_memblks knows that
a node has some memory so it can make the node online appropriately.
init_memory_less_node hack can be safely removed altogether now.
"
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-25 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 8:24 [RFC PATCH] x86, numa: always initialize all possible nodes Michal Hocko
2019-01-14 10:26 ` Michael Ellerman
2019-01-14 11:48 ` Michal Hocko
2019-01-15 5:32 ` Pingfan Liu
2019-01-24 14:17 ` Michal Hocko
2019-01-24 17:51 ` Mike Rapoport
2019-01-25 10:40 ` Michal Hocko [this message]
2019-01-25 19:25 ` Mike Rapoport
2019-01-24 19:10 ` Dave Hansen
2019-01-25 10:50 ` Michal Hocko
2019-02-11 13:49 ` Ingo Molnar
2019-02-11 14:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125104023.GI3560@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=dave.hansen@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
--cc=rppt@linux.ibm.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).