From: David Miller <davem@davemloft.net>
To: Mathias.Thore@infinera.com
Cc: David.Gounaris@infinera.com, netdev@vger.kernel.org,
leoyang.li@nxp.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping device
Date: Tue, 29 Jan 2019 15:33:50 -0800 (PST) [thread overview]
Message-ID: <20190129.153350.778783567985515916.davem@davemloft.net> (raw)
In-Reply-To: <DM6PR10MB3721D7BA109A3823D9DACF1984970@DM6PR10MB3721.namprd10.prod.outlook.com>
From: Mathias Thore <Mathias.Thore@infinera.com>
Date: Tue, 29 Jan 2019 08:07:54 +0000
> Is there a scenario where we are clearing the TX ring but don't want to reset the BQL TX queue?
>
> I think it makes sense to keep it in ucc_geth_free_tx since the
> reason it is needed isn't the timeout per se, but rather the
> clearing of the TX ring. This way, it will be performed no matter
> why the driver ends up calling this function.
I absolutely think the BQL reset should remain in ucc_geth_free_tx().
That way if another callsite for ucc_geth_free_tx() emerges that does
need the BQL queue reset, it won't be "forgotten".
next prev parent reply other threads:[~2019-01-29 23:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 9:07 [PATCH] ucc_geth: Reset BQL queue when stopping device Mathias Thore
2019-01-28 9:48 ` Christophe Leroy
2019-01-28 14:36 ` Mathias Thore
2019-01-28 21:36 ` Li Yang
2019-01-29 8:07 ` Mathias Thore
2019-01-29 19:50 ` Li Yang
2019-01-29 23:33 ` David Miller [this message]
2019-01-30 18:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129.153350.778783567985515916.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Gounaris@infinera.com \
--cc=Mathias.Thore@infinera.com \
--cc=leoyang.li@nxp.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).