From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Mathias Thore <mathias.thore@infinera.com>,
leoyang.li@nxp.com, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, david.gounaris@infinera.com,
joakim.tjernlund@infinera.com
Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping device
Date: Mon, 28 Jan 2019 10:48:52 +0100 [thread overview]
Message-ID: <6bc7e64a-b91a-cb6e-ed65-5e412cef3a76@c-s.fr> (raw)
In-Reply-To: <20190128090747.15851-1-mathias.thore@infinera.com>
Hi,
Le 28/01/2019 à 10:07, Mathias Thore a écrit :
> After a timeout event caused by for example a broadcast storm, when
> the MAC and PHY are reset, the BQL TX queue needs to be reset as
> well. Otherwise, the device will exhibit severe performance issues
> even after the storm has ended.
What are the symptomns ?
Is this reset needed on any network driver in that case, or is it
something particular for the ucc_geth ?
For instance, the freescale fs_enet doesn't have that reset. Should it
have it too ?
Christophe
>
> Co-authored-by: David Gounaris <david.gounaris@infinera.com>
> Signed-off-by: Mathias Thore <mathias.thore@infinera.com>
> ---
> drivers/net/ethernet/freescale/ucc_geth.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
> index c3d539e209ed..eb3e65e8868f 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -1879,6 +1879,8 @@ static void ucc_geth_free_tx(struct ucc_geth_private *ugeth)
> u16 i, j;
> u8 __iomem *bd;
>
> + netdev_reset_queue(ugeth->ndev);
> +
> ug_info = ugeth->ug_info;
> uf_info = &ug_info->uf_info;
>
>
next prev parent reply other threads:[~2019-01-28 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 9:07 [PATCH] ucc_geth: Reset BQL queue when stopping device Mathias Thore
2019-01-28 9:48 ` Christophe Leroy [this message]
2019-01-28 14:36 ` Mathias Thore
2019-01-28 21:36 ` Li Yang
2019-01-29 8:07 ` Mathias Thore
2019-01-29 19:50 ` Li Yang
2019-01-29 23:33 ` David Miller
2019-01-30 18:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc7e64a-b91a-cb6e-ed65-5e412cef3a76@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=david.gounaris@infinera.com \
--cc=joakim.tjernlund@infinera.com \
--cc=leoyang.li@nxp.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mathias.thore@infinera.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).