linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/mm: Check secondary hash page table
@ 2019-02-12 23:29 Rashmica Gupta
  2019-03-04  0:48 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Rashmica Gupta @ 2019-02-12 23:29 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Rashmica Gupta, paulus

We were always calling base_hpte_find() with primary = true,
even when we wanted to check the secondary table...

Fixes: 1515ab932156 powerpc/mm: Dump hash table

Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
---

Thanks Paul for spotting this :)

 arch/powerpc/mm/dump_hashpagetable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/dump_hashpagetable.c b/arch/powerpc/mm/dump_hashpagetable.c
index 869294695048..b430e4e08af6 100644
--- a/arch/powerpc/mm/dump_hashpagetable.c
+++ b/arch/powerpc/mm/dump_hashpagetable.c
@@ -342,7 +342,7 @@ static unsigned long hpte_find(struct pg_state *st, unsigned long ea, int psize)
 
 	/* Look in secondary table */
 	if (slot == -1)
-		slot = base_hpte_find(ea, psize, true, &v, &r);
+		slot = base_hpte_find(ea, psize, false, &v, &r);
 
 	/* No entry found */
 	if (slot == -1)
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: powerpc/mm: Check secondary hash page table
  2019-02-12 23:29 [PATCH] powerpc/mm: Check secondary hash page table Rashmica Gupta
@ 2019-03-04  0:48 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2019-03-04  0:48 UTC (permalink / raw)
  To: Rashmica Gupta, linuxppc-dev; +Cc: Rashmica Gupta, paulus

On Tue, 2019-02-12 at 23:29:49 UTC, Rashmica Gupta wrote:
> We were always calling base_hpte_find() with primary = true,
> even when we wanted to check the secondary table...
> 
> Fixes: 1515ab932156 powerpc/mm: Dump hash table
> 
> Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/790845e2f12709d273d08ea7a2af7c25

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-04  0:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 23:29 [PATCH] powerpc/mm: Check secondary hash page table Rashmica Gupta
2019-03-04  0:48 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).