From: Christoph Hellwig <hch@lst.de>
To: Ram Pai <linuxram@us.ibm.com>
Cc: andmike@us.ibm.com, sukadev@linux.vnet.ibm.com,
mdroth@linux.vnet.ibm.com, b.zolnierkie@samsung.com,
jasowang@redhat.com, aik@linux.ibm.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, paul.burton@mips.com,
robin.murphy@arm.com, m.szyprowski@samsung.com,
linuxppc-dev@lists.ozlabs.org, hch@lst.de,
david@gibson.dropbear.id.au
Subject: Re: [PATCH 2/2] virtio_ring: Use DMA API if memory is encrypted
Date: Tue, 15 Oct 2019 09:35:01 +0200 [thread overview]
Message-ID: <20191015073501.GA32345@lst.de> (raw)
In-Reply-To: <1570843519-8696-3-git-send-email-linuxram@us.ibm.com>
On Fri, Oct 11, 2019 at 06:25:19PM -0700, Ram Pai wrote:
> From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>
> Normally, virtio enables DMA API with VIRTIO_F_IOMMU_PLATFORM, which must
> be set by both device and guest driver. However, as a hack, when DMA API
> returns physical addresses, guest driver can use the DMA API; even though
> device does not set VIRTIO_F_IOMMU_PLATFORM and just uses physical
> addresses.
Sorry, but this is a complete bullshit hack. Driver must always use
the DMA API if they do DMA, and if virtio devices use physical addresses
that needs to be returned through the platform firmware interfaces for
the dma setup. If you don't do that yet (which based on previous
informations you don't), you need to fix it, and we can then quirk
old implementations that already are out in the field.
In other words: we finally need to fix that virtio mess and not pile
hacks on top of hacks.
next prev parent reply other threads:[~2019-10-15 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 1:25 [PATCH 0/2] virtio: Support encrypted memory on powerpc secure guests Ram Pai
2019-10-12 1:25 ` [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr() Ram Pai
2019-10-12 1:25 ` [PATCH 2/2] virtio_ring: Use DMA API if memory is encrypted Ram Pai
2019-10-14 4:52 ` David Gibson
2019-10-15 7:35 ` Christoph Hellwig [this message]
2019-10-16 7:55 ` Ram Pai
2019-10-17 2:33 ` Jason Wang
2019-10-21 8:36 ` David Gibson
2019-10-14 4:51 ` [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr() David Gibson
2019-10-14 10:29 ` Robin Murphy
2019-10-15 7:30 ` Ram Pai
2019-10-15 7:31 ` Christoph Hellwig
2019-10-12 1:36 ` [PATCH 0/2] virtio: Support encrypted memory on powerpc secure guests Ram Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015073501.GA32345@lst.de \
--to=hch@lst.de \
--cc=aik@linux.ibm.com \
--cc=andmike@us.ibm.com \
--cc=b.zolnierkie@samsung.com \
--cc=david@gibson.dropbear.id.au \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=m.szyprowski@samsung.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=paul.burton@mips.com \
--cc=robin.murphy@arm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).