* [PATCH] powerpc/shared: include correct header for static key
@ 2019-12-23 13:31 Jason A. Donenfeld
2020-01-06 5:23 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Jason A. Donenfeld @ 2019-12-23 13:31 UTC (permalink / raw)
To: pauld, longman, mpe, linuxppc-dev, linux-kernel
Cc: Jason A. Donenfeld, Srikar Dronamraju
Recently, the spinlock implementation grew a static key optimization,
but the jump_label.h header include was left out, leading to build
errors:
linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
44 | if (!static_branch_unlikely(&shared_processor))
This commit adds the missing header.
Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
arch/powerpc/include/asm/spinlock.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h
index 1b55fc08f853..860228e917dc 100644
--- a/arch/powerpc/include/asm/spinlock.h
+++ b/arch/powerpc/include/asm/spinlock.h
@@ -15,6 +15,7 @@
*
* (the type definitions are in asm/spinlock_types.h)
*/
+#include <linux/jump_label.h>
#include <linux/irqflags.h>
#ifdef CONFIG_PPC64
#include <asm/paca.h>
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/shared: include correct header for static key
2019-12-23 13:31 [PATCH] powerpc/shared: include correct header for static key Jason A. Donenfeld
@ 2020-01-06 5:23 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-01-06 5:23 UTC (permalink / raw)
To: Jason A. Donenfeld, pauld, longman, linuxppc-dev, linux-kernel
Cc: Jason A. Donenfeld, Srikar Dronamraju
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Mon, 2019-12-23 at 13:31:47 UTC, "Jason A. Donenfeld" wrote:
> Recently, the spinlock implementation grew a static key optimization,
> but the jump_label.h header include was left out, leading to build
> errors:
>
> linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> 44 | if (!static_branch_unlikely(&shared_processor))
>
> This commit adds the missing header.
>
> Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/6da3eced8c5f3b03340b0c395bacd552c4d52411
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/shared: include correct header for static key
[not found] <xagsmtp2.20191223133223.8837@vmsdvm3.vnet.ibm.com>
@ 2019-12-24 16:22 ` Srikar Dronamraju
0 siblings, 0 replies; 3+ messages in thread
From: Srikar Dronamraju @ 2019-12-24 16:22 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: longman, pauld, linuxppc-dev, linux-kernel
* Jason A. Donenfeld <Jason@zx2c4.com> [2019-12-23 14:31:47]:
> Recently, the spinlock implementation grew a static key optimization,
> but the jump_label.h header include was left out, leading to build
> errors:
>
> linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ???static_branch_unlikely??? [-Werror=implicit-function-declaration]
> 44 | if (!static_branch_unlikely(&shared_processor))
>
> This commit adds the missing header.
Right, This was in v4 version of the patchset
(http://lkml.kernel.org/r/20191212085344.17357-1-srikar@linux.vnet.ibm.com)
but we missed it in the final v5 version.
Thanks for noticing and fixing it.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
> Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> arch/powerpc/include/asm/spinlock.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h
> index 1b55fc08f853..860228e917dc 100644
> --- a/arch/powerpc/include/asm/spinlock.h
> +++ b/arch/powerpc/include/asm/spinlock.h
> @@ -15,6 +15,7 @@
> *
> * (the type definitions are in asm/spinlock_types.h)
> */
> +#include <linux/jump_label.h>
> #include <linux/irqflags.h>
> #ifdef CONFIG_PPC64
> #include <asm/paca.h>
> --
> 2.24.1
>
--
Thanks and Regards
Srikar Dronamraju
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-06 5:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 13:31 [PATCH] powerpc/shared: include correct header for static key Jason A. Donenfeld
2020-01-06 5:23 ` Michael Ellerman
[not found] <xagsmtp2.20191223133223.8837@vmsdvm3.vnet.ibm.com>
2019-12-24 16:22 ` Srikar Dronamraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).