From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Christopher Lameter <cl@linux.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline
Date: Tue, 12 May 2020 16:12:26 +0530 [thread overview]
Message-ID: <20200512104226.GE1961@linux.vnet.ibm.com> (raw)
In-Reply-To: <45d50d80-c998-9372-42eb-ca753a7258b9@redhat.com>
* David Hildenbrand <david@redhat.com> [2020-05-12 09:49:05]:
> On 11.05.20 19:47, Srikar Dronamraju wrote:
> > * David Hildenbrand <david@redhat.com> [2020-05-08 15:42:12]:
> >
> >
> > [root@localhost ~]# cat /sys/devices/system/node/online
> > 0
> > [root@localhost ~]# cat /sys/devices/system/node/possible
> > 0-1
> >
> > Even without my patch, both the combinations, I am still unable to see a
> > cpuless, memoryless node being online. And the interesting part being even
>
> Yeah, I think on x86, all memory-less and cpu-less nodes are offline as
> default. Especially when hotunplugging cpus/memory, we set them offline
> as well.
I also came to the same conclusion that we may not have a cpuless,memoryless
node on x86.
>
> But as Michal mentioned, the node handling code is complicated and
> differs between various architectures.
>
I do agree that node handling code differs across various architectures and
quite complicated.
> > if I mark node 0 as cpuless,memoryless and node 1 as actual node, the system
> > somewhere marks node 0 as the actual node.
>
> Is the kernel maybe mapping PXM 1 to node 0 in that case, because it
> always requires node 0 to be online/contain memory? Would be interesting
> what happens if you hotplug a DIMM to (QEMU )node 0 - if PXM 0 will be
> mapped to node 1 then as well.
>
Satheesh Rajendra had tried with cpu hotplug on a similar setup and we found
that it crashes the x86 system.
reference: https://bugzilla.kernel.org/show_bug.cgi?id=202187
Even if we were able to hotplug 1 DIMM memory into node 1, that would no
more be a memoryless node.
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2020-05-12 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:38 [PATCH v2 0/3] Offline memoryless cpuless node 0 Srikar Dronamraju
2020-04-28 9:38 ` [PATCH v2 1/3] powerpc/numa: Set numa_node for all possible cpus Srikar Dronamraju
2020-04-28 9:38 ` [PATCH v2 2/3] powerpc/numa: Prefer node id queried from vphn Srikar Dronamraju
2020-04-29 6:52 ` Gautham R Shenoy
2020-04-30 4:34 ` Srikar Dronamraju
2020-04-28 9:38 ` [PATCH v2 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline Srikar Dronamraju
2020-04-28 23:59 ` Andrew Morton
2020-04-29 1:41 ` Srikar Dronamraju
2020-04-29 12:22 ` Michal Hocko
2020-04-30 7:18 ` Srikar Dronamraju
2020-05-04 9:37 ` Michal Hocko
2020-05-08 13:03 ` Srikar Dronamraju
2020-05-08 13:39 ` David Hildenbrand
2020-05-08 13:42 ` David Hildenbrand
2020-05-11 17:47 ` Srikar Dronamraju
2020-05-12 7:49 ` David Hildenbrand
2020-05-12 10:42 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512104226.GE1961@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=sathnaga@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).