* [PATCH 06/11] powerpc/xmon: constify sysrq_key_op [not found] <20200513214351.2138580-1-emil.l.velikov@gmail.com> @ 2020-05-13 21:43 ` Emil Velikov 2020-05-14 3:44 ` Michael Ellerman 0 siblings, 1 reply; 2+ messages in thread From: Emil Velikov @ 2020-05-13 21:43 UTC (permalink / raw) To: dri-devel Cc: Jiri Slaby, emil.l.velikov, linux-kernel, Paul Mackerras, Greg Kroah-Hartman, linuxppc-dev With earlier commits, the API no longer discards the const-ness of the sysrq_key_op. As such we can add the notation. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-kernel@vger.kernel.org Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- Please keep me in the CC list, as I'm not subscribed to the list. IMHO it would be better if this gets merged this via the tty tree. --- arch/powerpc/xmon/xmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 7af840c0fc93..0d8ca5c9f131 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -3842,7 +3842,7 @@ static void sysrq_handle_xmon(int key) xmon_init(0); } -static struct sysrq_key_op sysrq_xmon_op = { +static const struct sysrq_key_op sysrq_xmon_op = { .handler = sysrq_handle_xmon, .help_msg = "xmon(x)", .action_msg = "Entering xmon", -- 2.25.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 06/11] powerpc/xmon: constify sysrq_key_op 2020-05-13 21:43 ` [PATCH 06/11] powerpc/xmon: constify sysrq_key_op Emil Velikov @ 2020-05-14 3:44 ` Michael Ellerman 0 siblings, 0 replies; 2+ messages in thread From: Michael Ellerman @ 2020-05-14 3:44 UTC (permalink / raw) To: Emil Velikov, dri-devel Cc: Greg Kroah-Hartman, Jiri Slaby, emil.l.velikov, linux-kernel, Paul Mackerras, linuxppc-dev Emil Velikov <emil.l.velikov@gmail.com> writes: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. Fine by me. Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index 7af840c0fc93..0d8ca5c9f131 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -3842,7 +3842,7 @@ static void sysrq_handle_xmon(int key) > xmon_init(0); > } > > -static struct sysrq_key_op sysrq_xmon_op = { > +static const struct sysrq_key_op sysrq_xmon_op = { > .handler = sysrq_handle_xmon, > .help_msg = "xmon(x)", > .action_msg = "Entering xmon", > -- > 2.25.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-14 3:46 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200513214351.2138580-1-emil.l.velikov@gmail.com> 2020-05-13 21:43 ` [PATCH 06/11] powerpc/xmon: constify sysrq_key_op Emil Velikov 2020-05-14 3:44 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).