* [PATCH] ibmvscsi: don't send host info in adapter info MAD after LPM
@ 2020-06-03 20:36 Tyrel Datwyler
2020-06-10 2:02 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tyrel Datwyler @ 2020-06-03 20:36 UTC (permalink / raw)
To: james.bottomley
Cc: Tyrel Datwyler, brking, linuxppc-dev, linux-scsi, martin.petersen
The adatper info MAD is used to send the client info and receive the
host info as a response. A peristent buffer is used and as such the
client info is overwritten after the response. During the course of
a normal adapter reset the client info is refreshed in the buffer in
preparation for sending the adapter info MAD.
However, in the special case of LPM where we reenable the CRQ instead
of a full CRQ teardown and reset we fail to refresh the client info in
the adapter info buffer. As a result after Live Partition Migration
(LPM) we erroneously report the hosts info as our own.
Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 59f0f1030c54..c5711c659b51 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -415,6 +415,8 @@ static int ibmvscsi_reenable_crq_queue(struct crq_queue *queue,
int rc = 0;
struct vio_dev *vdev = to_vio_dev(hostdata->dev);
+ set_adapter_info(hostdata);
+
/* Re-enable the CRQ */
do {
if (rc)
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ibmvscsi: don't send host info in adapter info MAD after LPM
2020-06-03 20:36 [PATCH] ibmvscsi: don't send host info in adapter info MAD after LPM Tyrel Datwyler
@ 2020-06-10 2:02 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-06-10 2:02 UTC (permalink / raw)
To: Tyrel Datwyler, james.bottomley
Cc: brking, linuxppc-dev, linux-scsi, Martin K . Petersen
On Wed, 3 Jun 2020 15:36:32 -0500, Tyrel Datwyler wrote:
> The adatper info MAD is used to send the client info and receive the
> host info as a response. A peristent buffer is used and as such the
> client info is overwritten after the response. During the course of
> a normal adapter reset the client info is refreshed in the buffer in
> preparation for sending the adapter info MAD.
>
> However, in the special case of LPM where we reenable the CRQ instead
> of a full CRQ teardown and reset we fail to refresh the client info in
> the adapter info buffer. As a result after Live Partition Migration
> (LPM) we erroneously report the hosts info as our own.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: Don't send host info in adapter info MAD after LPM
https://git.kernel.org/mkp/scsi/c/4919b33b63c8
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-10 2:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 20:36 [PATCH] ibmvscsi: don't send host info in adapter info MAD after LPM Tyrel Datwyler
2020-06-10 2:02 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).