linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH trivial] ppc64/mm: remove comment that is no longer valid
@ 2020-07-21  9:19 Santosh Sivaraj
  2020-07-24 13:25 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Santosh Sivaraj @ 2020-07-21  9:19 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Santosh Sivaraj

hash_low_64.S was removed in [1] and since flush_hash_page is not called
from any assembly routine.

[1]: commit a43c0eb8364c0 ("powerpc/mm: Convert 4k insert from asm to C")

Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
 arch/powerpc/mm/book3s64/hash_utils.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/powerpc/mm/book3s64/hash_utils.c b/arch/powerpc/mm/book3s64/hash_utils.c
index 468169e33c86f..90ee0be3281a9 100644
--- a/arch/powerpc/mm/book3s64/hash_utils.c
+++ b/arch/powerpc/mm/book3s64/hash_utils.c
@@ -1706,10 +1706,6 @@ unsigned long pte_get_hash_gslot(unsigned long vpn, unsigned long shift,
 	return gslot;
 }
 
-/*
- * WARNING: This is called from hash_low_64.S, if you change this prototype,
- *          do not forget to update the assembly call site !
- */
 void flush_hash_page(unsigned long vpn, real_pte_t pte, int psize, int ssize,
 		     unsigned long flags)
 {
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH trivial] ppc64/mm: remove comment that is no longer valid
  2020-07-21  9:19 [PATCH trivial] ppc64/mm: remove comment that is no longer valid Santosh Sivaraj
@ 2020-07-24 13:25 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2020-07-24 13:25 UTC (permalink / raw)
  To: Santosh Sivaraj, linuxppc-dev

On Tue, 21 Jul 2020 14:49:15 +0530, Santosh Sivaraj wrote:
> hash_low_64.S was removed in [1] and since flush_hash_page is not called
> from any assembly routine.
> 
> [1]: commit a43c0eb8364c0 ("powerpc/mm: Convert 4k insert from asm to C")

Applied to powerpc/next.

[1/1] powerpc/mm/hash64: Remove comment that is no longer valid
      https://git.kernel.org/powerpc/c/69507b984ddce803df81215cc7813825189adafa

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-24 15:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21  9:19 [PATCH trivial] ppc64/mm: remove comment that is no longer valid Santosh Sivaraj
2020-07-24 13:25 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).