* [PATCH] powerpc: powernv: Remove unneeded variable: "rc"
@ 2021-03-26 11:53 dingsenjie
2021-03-26 14:59 ` Andrew Donnellan
2021-03-31 1:09 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: dingsenjie @ 2021-03-26 11:53 UTC (permalink / raw)
To: mpe, benh, paulus; +Cc: dingsenjie, linuxppc-dev, linux-kernel
From: dingsenjie <dingsenjie@yulong.com>
Remove unneeded variable: "rc".
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
arch/powerpc/platforms/powernv/opal-prd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal-prd.c b/arch/powerpc/platforms/powernv/opal-prd.c
index deddaeb..a191f4c 100644
--- a/arch/powerpc/platforms/powernv/opal-prd.c
+++ b/arch/powerpc/platforms/powernv/opal-prd.c
@@ -105,7 +105,6 @@ static int opal_prd_mmap(struct file *file, struct vm_area_struct *vma)
{
size_t addr, size;
pgprot_t page_prot;
- int rc;
pr_devel("opal_prd_mmap(0x%016lx, 0x%016lx, 0x%lx, 0x%lx)\n",
vma->vm_start, vma->vm_end, vma->vm_pgoff,
@@ -121,10 +120,8 @@ static int opal_prd_mmap(struct file *file, struct vm_area_struct *vma)
page_prot = phys_mem_access_prot(file, vma->vm_pgoff,
size, vma->vm_page_prot);
- rc = remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff, size,
+ return remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff, size,
page_prot);
-
- return rc;
}
static bool opal_msg_queue_empty(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: powernv: Remove unneeded variable: "rc"
2021-03-26 11:53 [PATCH] powerpc: powernv: Remove unneeded variable: "rc" dingsenjie
@ 2021-03-26 14:59 ` Andrew Donnellan
2021-03-31 1:09 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2021-03-26 14:59 UTC (permalink / raw)
To: dingsenjie, mpe, benh, paulus; +Cc: dingsenjie, linuxppc-dev, linux-kernel
On 26/3/21 10:53 pm, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
>
> Remove unneeded variable: "rc".
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
This looks obviously correct and doesn't raise any checkpatch warnings.
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: powernv: Remove unneeded variable: "rc"
2021-03-26 11:53 [PATCH] powerpc: powernv: Remove unneeded variable: "rc" dingsenjie
2021-03-26 14:59 ` Andrew Donnellan
@ 2021-03-31 1:09 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-03-31 1:09 UTC (permalink / raw)
To: dingsenjie, mpe, paulus, benh; +Cc: dingsenjie, linuxppc-dev, linux-kernel
On Fri, 26 Mar 2021 19:53:56 +0800, dingsenjie@163.com wrote:
> Remove unneeded variable: "rc".
Applied to powerpc/next.
[1/1] powerpc: powernv: Remove unneeded variable: "rc"
https://git.kernel.org/powerpc/c/69931cc387cca289e0415c79ce5389119670066d
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-31 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 11:53 [PATCH] powerpc: powernv: Remove unneeded variable: "rc" dingsenjie
2021-03-26 14:59 ` Andrew Donnellan
2021-03-31 1:09 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).