* [PATCH -next] powerpc/xmon: Make symbol 'spu_inst_dump' static
@ 2021-04-09 7:01 Pu Lehui
2021-04-19 3:59 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Pu Lehui @ 2021-04-09 7:01 UTC (permalink / raw)
To: mpe, benh, paulus, jniethe5, alistair, ravi.bangoria, pmladek,
john.ogness, npiggin, christophe.leroy, rppt, maddy
Cc: zhangjinhao2, yangjihong1, linuxppc-dev, linux-kernel, pulehui
Fix sparse warning:
arch/powerpc/xmon/xmon.c:4216:1: warning:
symbol 'spu_inst_dump' was not declared. Should it be static?
This symbol is not used outside of xmon.c, so make it static.
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
arch/powerpc/xmon/xmon.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index bf7d69625a2e..d4ae2a25781f 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -4212,8 +4212,7 @@ static void dump_spu_fields(struct spu *spu)
DUMP_FIELD(spu, "0x%p", pdata);
}
-int
-spu_inst_dump(unsigned long adr, long count, int praddr)
+static int spu_inst_dump(unsigned long adr, long count, int praddr)
{
return generic_inst_dump(adr, count, praddr, print_insn_spu);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] powerpc/xmon: Make symbol 'spu_inst_dump' static
2021-04-09 7:01 [PATCH -next] powerpc/xmon: Make symbol 'spu_inst_dump' static Pu Lehui
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: npiggin, benh, mpe, alistair, maddy, christophe.leroy,
ravi.bangoria, rppt, paulus, john.ogness, jniethe5, pmladek,
Pu Lehui
Cc: zhangjinhao2, yangjihong1, linuxppc-dev, linux-kernel
On Fri, 9 Apr 2021 15:01:51 +0800, Pu Lehui wrote:
> Fix sparse warning:
>
> arch/powerpc/xmon/xmon.c:4216:1: warning:
> symbol 'spu_inst_dump' was not declared. Should it be static?
>
> This symbol is not used outside of xmon.c, so make it static.
Applied to powerpc/next.
[1/1] powerpc/xmon: Make symbol 'spu_inst_dump' static
https://git.kernel.org/powerpc/c/f234ad405a35262ed2d8dd2d29fc633908dce955
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-19 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 7:01 [PATCH -next] powerpc/xmon: Make symbol 'spu_inst_dump' static Pu Lehui
2021-04-19 3:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).