* [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response
@ 2021-09-23 3:38 Sasha Levin
2021-09-23 7:33 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2021-09-23 3:38 UTC (permalink / raw)
To: linux-kernel, stable
Cc: Sasha Levin, netdev, drt, kuba, Sukadev Bhattiprolu,
linuxppc-dev, David S . Miller
From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
[ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ]
If a failover occurs before a login response is received, the login
response buffer maybe undefined. Check that there was no failover
before accessing the login response buffer.
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/net/ethernet/ibm/ibmvnic.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 3134c1988db3..bb8d0a0f48ee 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -4478,6 +4478,14 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq,
return 0;
}
+ if (adapter->failover_pending) {
+ adapter->init_done_rc = -EAGAIN;
+ netdev_dbg(netdev, "Failover pending, ignoring login response\n");
+ complete(&adapter->init_done);
+ /* login response buffer will be released on reset */
+ return 0;
+ }
+
netdev->mtu = adapter->req_mtu - ETH_HLEN;
netdev_dbg(adapter->netdev, "Login Response Buffer:\n");
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response
2021-09-23 3:38 [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response Sasha Levin
@ 2021-09-23 7:33 ` Pavel Machek
2021-09-24 11:47 ` Sasha Levin
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2021-09-23 7:33 UTC (permalink / raw)
To: Sasha Levin
Cc: linux-kernel, stable, netdev, drt, kuba, Sukadev Bhattiprolu,
linuxppc-dev, David S . Miller
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Hi!
Something went wrong with this series. I only see first 7 patches. I
thought it might be local problem, but I only see 7 patches on lore...
https://lore.kernel.org/lkml/20210923033839.1421034-1-sashal@kernel.org/
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response
2021-09-23 7:33 ` Pavel Machek
@ 2021-09-24 11:47 ` Sasha Levin
0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2021-09-24 11:47 UTC (permalink / raw)
To: Pavel Machek
Cc: linux-kernel, stable, netdev, drt, kuba, Sukadev Bhattiprolu,
linuxppc-dev, David S . Miller
On Thu, Sep 23, 2021 at 09:33:47AM +0200, Pavel Machek wrote:
>Hi!
>
>Something went wrong with this series. I only see first 7 patches. I
>thought it might be local problem, but I only see 7 patches on lore...
Huh, yes, apparently git-send-email timed out. I'll resend. Thanks!
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-24 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 3:38 [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response Sasha Levin
2021-09-23 7:33 ` Pavel Machek
2021-09-24 11:47 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).