* [PATCH] selftests/powerpc: Use date instead of EPOCHSECONDS in mitigation-patching.sh
@ 2021-10-25 10:24 Russell Currey
2021-11-02 10:12 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Russell Currey @ 2021-10-25 10:24 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Russell Currey
The EPOCHSECONDS environment variable was added in bash 5.0 (released
2019). Some distributions of the "stable" and "long-term" variety ship
older versions of bash than this, so swap to using the date command
instead.
"%s" was added to coreutils `date` in 1993 so we should be good, but who
knows, it is a GNU extension and not part of the POSIX spec for `date`.
Signed-off-by: Russell Currey <ruscur@russell.cc>
---
.../testing/selftests/powerpc/security/mitigation-patching.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/powerpc/security/mitigation-patching.sh b/tools/testing/selftests/powerpc/security/mitigation-patching.sh
index 00197acb7ff1..b0b20e0b4e30 100755
--- a/tools/testing/selftests/powerpc/security/mitigation-patching.sh
+++ b/tools/testing/selftests/powerpc/security/mitigation-patching.sh
@@ -13,7 +13,7 @@ function do_one
orig=$(cat "$mitigation")
- start=$EPOCHSECONDS
+ start=$(date +%s)
now=$start
while [[ $((now-start)) -lt "$TIMEOUT" ]]
@@ -21,7 +21,7 @@ function do_one
echo 0 > "$mitigation"
echo 1 > "$mitigation"
- now=$EPOCHSECONDS
+ now=$(date +%s)
done
echo "$orig" > "$mitigation"
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/powerpc: Use date instead of EPOCHSECONDS in mitigation-patching.sh
2021-10-25 10:24 [PATCH] selftests/powerpc: Use date instead of EPOCHSECONDS in mitigation-patching.sh Russell Currey
@ 2021-11-02 10:12 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-11-02 10:12 UTC (permalink / raw)
To: Russell Currey, linuxppc-dev
On Mon, 25 Oct 2021 20:24:36 +1000, Russell Currey wrote:
> The EPOCHSECONDS environment variable was added in bash 5.0 (released
> 2019). Some distributions of the "stable" and "long-term" variety ship
> older versions of bash than this, so swap to using the date command
> instead.
>
> "%s" was added to coreutils `date` in 1993 so we should be good, but who
> knows, it is a GNU extension and not part of the POSIX spec for `date`.
>
> [...]
Applied to powerpc/next.
[1/1] selftests/powerpc: Use date instead of EPOCHSECONDS in mitigation-patching.sh
https://git.kernel.org/powerpc/c/cb662608e546d755e3e1b51b30a269459323bf24
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-02 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 10:24 [PATCH] selftests/powerpc: Use date instead of EPOCHSECONDS in mitigation-patching.sh Russell Currey
2021-11-02 10:12 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).