* [PATCH] tty: serial: Fix refcount leak bug in ucc_uart.c
@ 2022-06-18 6:08 Liang He
2022-06-18 17:07 ` Timur Tabi
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-18 6:08 UTC (permalink / raw)
To: timur, gregkh, jirislaby; +Cc: linuxppc-dev, windhl, linux-kernel, linux-serial
In soc_info(), of_find_node_by_type() will return a node pointer
with refcount incremented. We should use of_node_put() when it is
not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
drivers/tty/serial/ucc_uart.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 6000853973c1..3cc9ef08455c 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1137,6 +1137,8 @@ static unsigned int soc_info(unsigned int *rev_h, unsigned int *rev_l)
/* No compatible property, so try the name. */
soc_string = np->name;
+ of_node_put(np);
+
/* Extract the SOC number from the "PowerPC," string */
if ((sscanf(soc_string, "PowerPC,%u", &soc) != 1) || !soc)
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-18 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-18 6:08 [PATCH] tty: serial: Fix refcount leak bug in ucc_uart.c Liang He
2022-06-18 17:07 ` Timur Tabi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).