linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name
@ 2022-06-24 14:16 Serge Semin
  2022-06-24 14:16 ` [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT " Serge Semin
                   ` (4 more replies)
  0 siblings, 5 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 14:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Felipe Balbi, Michael Ellerman,
	Vladimir Zapolskiy, Alexey Brodkin, Vineet Gupta, Rob Herring,
	Rob Herring, Greg Kroah-Hartman, Krzysztof Kozlowski, linux-usb
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Serge Semin, Paul Mackerras, linux-arm-msm,
	linux-snps-arc, linuxppc-dev, linux-arm-kernel

As the subject states this series is an attempt to harmonize the xHCI,
EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the
framework of the patchset [1].

Firstly as Krzysztof suggested we've deprecated a support of DWC USB3
controllers with "synopsys,"-vendor prefix compatible string in favor of
the ones with valid "snps,"-prefix. It's done in all the DTS files,
which have been unfortunate to define such nodes.

Secondly we suggest to fix the snps,quirk-frame-length-adjustment property
declaration in the Amlogic meson-g12-common.dtsi DTS file, since it has
been erroneously declared as boolean while having uint32 type. Neil said
it was ok to init that property with 0x20 value.

Thirdly the main part of the patchset concern fixing the xHCI, EHCI/OHCI
and DWC USB3 DT nodes name as in accordance with their DT schema the
corresponding node name is suppose to comply with the Generic USB HCD DT
schema, which requires the USB nodes to have the name acceptable by the
regexp: "^usb(@.*)?". Such requirement had been applicable even before we
introduced the new DT schema in [1], but as we can see it hasn't been
strictly implemented for a lot the DTS files. Since DT schema is now
available the automated DTS validation shall make sure that the rule isn't
violated.

Note most of these patches have been a part of the last three patches of
[1]. But since there is no way to have them merged in in a combined
manner, I had to move them to the dedicated series and split them up so to
be accepted by the corresponding subsystem maintainers one-by-one.

[1] Link: https://lore.kernel.org/linux-usb/20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru/
Changelog v1:
- As Krzysztof suggested I've created a script which checked whether the
  node names had been also updated in all the depended dts files. As a
  result I found two more files which should have been also modified:
  arch/arc/boot/dts/{axc003.dtsi,axc003_idu.dtsi}
- Correct the USB DWC3 nodes name found in
  arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} too.

Link: https://lore.kernel.org/linux-usb/20201020115959.2658-1-Sergey.Semin@baikalelectronics.ru
Changelog v2:
- Drop the patch:
  [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string
  and get back the one which marks the "synopsys,dwc3" compatible string
  as deprecated into the DT schema related series.
- Drop the patches:
  [PATCH 03/29] arm: dts: am437x: Correct DWC USB3 compatible string
  [PATCH 04/29] arm: dts: exynos: Correct DWC USB3 compatible string
  [PATCH 07/29] arm: dts: bcm53x: Harmonize EHCI/OHCI DT nodes name
  [PATCH 08/29] arm: dts: stm32: Harmonize EHCI/OHCI DT nodes name
  [PATCH 16/29] arm: dts: bcm5301x: Harmonize xHCI DT nodes name
  [PATCH 19/29] arm: dts: exynos: Harmonize DWC USB3 DT nodes name
  [PATCH 21/29] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name
  [PATCH 22/29] arm: dts: omap5: Harmonize DWC USB3 DT nodes name
  [PATCH 24/29] arm64: dts: allwinner: h6: Harmonize DWC USB3 DT nodes name
  [PATCH 26/29] arm64: dts: exynos: Harmonize DWC USB3 DT nodes name
  [PATCH 27/29] arm64: dts: layerscape: Harmonize DWC USB3 DT nodes name
  since they have been applied to the corresponding maintainers repos.
- Fix drivers/usb/dwc3/dwc3-qcom.c to be looking for the "usb@"-prefixed
  sub-node and falling back to the "dwc3@"-prefixed one on failure.

Link: https://lore.kernel.org/linux-usb/20201111091552.15593-1-Sergey.Semin@baikalelectronics.ru
Changelog v3:
- Drop the patches:
  [PATCH v2 04/18] arm: dts: hisi-x5hd2: Harmonize EHCI/OHCI DT nodes name
  [PATCH v2 06/18] arm64: dts: hisi: Harmonize EHCI/OHCI DT nodes name
  [PATCH v2 07/18] mips: dts: jz47x: Harmonize EHCI/OHCI DT nodes name
  [PATCH v2 08/18] mips: dts: sead3: Harmonize EHCI/OHCI DT nodes name
  [PATCH v2 09/18] mips: dts: ralink: mt7628a: Harmonize EHCI/OHCI DT nodes name
  [PATCH v2 11/18] arm64: dts: marvell: cp11x: Harmonize xHCI DT nodes name
  [PATCH v2 12/18] arm: dts: marvell: armada-375: Harmonize DWC USB3 DT nodes name
  [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name
  since they have been applied to the corresponding maintainers repos.

Link: https://lore.kernel.org/linux-usb/20201205155621.3045-1-Sergey.Semin@baikalelectronics.ru
Changelog v4:
- Just resend.

Link: https://lore.kernel.org/linux-usb/20201210091756.18057-1-Sergey.Semin@baikalelectronics.ru/
Changelog v5:
- Drop the patch:
  [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value
  since it has been applied to the corresponding maintainers repos.
- Get back the patch:
  [PATCH 21/29] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name
  as it has been missing in the kernel 5.11-rc7
- Rebase onto the kernel 5.11-rc7.

Link: https://lore.kernel.org/lkml/20210208135154.6645-1-Sergey.Semin@baikalelectronics.ru/
Changelog v6:
- Just resend and add linux-usb.vger.kernel.org to the list of Ccecipients.

Link: https://lore.kernel.org/linux-usb/20210210172850.20849-1-Sergey.Semin@baikalelectronics.ru
Link: https://lore.kernel.org/linux-usb/20210212205521.14280-1-Sergey.Semin@baikalelectronics.ru
Changelog v7:
- Replace "of_get_child_by_name(np, "usb") ?: of_get_child_by_name(np, "dwc3");"
  pattern with using of_get_compatible_child() method in the Qcom DWC3 driver.
- Drop the patches:
  [PATCH v6 01/10] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name
  [PATCH v6 02/10] arm: dts: keystone: Correct DWC USB3 compatible string
  [PATCH v6 06/10] arm: dts: keystone: Harmonize DWC USB3 DT nodes name
  since they have been applied to the corresponding maintainers repos.
- Cleanup the list of recipients.
- Rebase onto kernel 5.12-rc4.

Link: https://lore.kernel.org/lkml/20210324204836.29668-1-Sergey.Semin@baikalelectronics.ru/
Changelog v8:
- Just resend.

Link: https://lore.kernel.org/lkml/20210409113029.7144-1-Sergey.Semin@baikalelectronics.ru
Changelog v9:
- Drop the patches:
  [PATCH RESEND v8 1/8] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name
  [PATCH RESEND v8 7/8] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string
  since they have been applied to the corresponding maintainers repos.
- Rebase onto the kernel 5.19-rcX.

Cc: Khuong Dinh <khuong@os.amperecomputing.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-snps-arc@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

Serge Semin (5):
  arc: dts: Harmonize EHCI/OHCI DT nodes name
  arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name
  powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name
  arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  arm64: dts: apm: Harmonize DWC USB3 DT nodes name

 arch/arc/boot/dts/axc003.dtsi              | 4 ++--
 arch/arc/boot/dts/axc003_idu.dtsi          | 4 ++--
 arch/arc/boot/dts/axs10x_mb.dtsi           | 4 ++--
 arch/arc/boot/dts/hsdk.dts                 | 4 ++--
 arch/arc/boot/dts/vdk_axs10x_mb.dtsi       | 2 +-
 arch/arm/boot/dts/lpc18xx.dtsi             | 4 ++--
 arch/arm/boot/dts/stih407-family.dtsi      | 2 +-
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++--
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 6 +++---
 arch/powerpc/boot/dts/akebono.dts          | 6 +++---
 10 files changed, 20 insertions(+), 20 deletions(-)

-- 
2.35.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 14:16 [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
@ 2022-06-24 14:16 ` Serge Semin
  2022-06-24 22:11   ` Vineet Gupta
  2022-06-24 14:16 ` [PATCH RESEND v9 2/5] arm: dts: lpc18xx: " Serge Semin
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 20+ messages in thread
From: Serge Semin @ 2022-06-24 14:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Felipe Balbi, Michael Ellerman,
	Vladimir Zapolskiy, Alexey Brodkin, Vineet Gupta, Rob Herring,
	Rob Herring, Greg Kroah-Hartman, Krzysztof Kozlowski, linux-usb,
	Krzysztof Kozlowski, Vineet Gupta
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Serge Semin, Paul Mackerras, linux-arm-msm,
	linux-snps-arc, linuxppc-dev, linux-arm-kernel

In accordance with the Generic EHCI/OHCI bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
nodes are correctly named.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arc/boot/dts/axc003.dtsi        | 4 ++--
 arch/arc/boot/dts/axc003_idu.dtsi    | 4 ++--
 arch/arc/boot/dts/axs10x_mb.dtsi     | 4 ++--
 arch/arc/boot/dts/hsdk.dts           | 4 ++--
 arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arc/boot/dts/axc003.dtsi b/arch/arc/boot/dts/axc003.dtsi
index cd1edcf4f95e..3434c8131ecd 100644
--- a/arch/arc/boot/dts/axc003.dtsi
+++ b/arch/arc/boot/dts/axc003.dtsi
@@ -103,11 +103,11 @@ ethernet@18000 {
 			dma-coherent;
 		};
 
-		ehci@40000 {
+		usb@40000 {
 			dma-coherent;
 		};
 
-		ohci@60000 {
+		usb@60000 {
 			dma-coherent;
 		};
 
diff --git a/arch/arc/boot/dts/axc003_idu.dtsi b/arch/arc/boot/dts/axc003_idu.dtsi
index 70779386ca79..67556f4b7057 100644
--- a/arch/arc/boot/dts/axc003_idu.dtsi
+++ b/arch/arc/boot/dts/axc003_idu.dtsi
@@ -110,11 +110,11 @@ ethernet@18000 {
 			dma-coherent;
 		};
 
-		ehci@40000 {
+		usb@40000 {
 			dma-coherent;
 		};
 
-		ohci@60000 {
+		usb@60000 {
 			dma-coherent;
 		};
 
diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 99d3e7175bf7..b64435385304 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -87,13 +87,13 @@ gmac: ethernet@18000 {
 			mac-address = [00 00 00 00 00 00]; /* Filled in by U-Boot */
 		};
 
-		ehci@40000 {
+		usb@40000 {
 			compatible = "generic-ehci";
 			reg = < 0x40000 0x100 >;
 			interrupts = < 8 >;
 		};
 
-		ohci@60000 {
+		usb@60000 {
 			compatible = "generic-ohci";
 			reg = < 0x60000 0x100 >;
 			interrupts = < 8 >;
diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
index f48ba03e9b5e..6691f4255077 100644
--- a/arch/arc/boot/dts/hsdk.dts
+++ b/arch/arc/boot/dts/hsdk.dts
@@ -234,7 +234,7 @@ phy0: ethernet-phy@0 { /* Micrel KSZ9031 */
 			};
 		};
 
-		ohci@60000 {
+		usb@60000 {
 			compatible = "snps,hsdk-v1.0-ohci", "generic-ohci";
 			reg = <0x60000 0x100>;
 			interrupts = <15>;
@@ -242,7 +242,7 @@ ohci@60000 {
 			dma-coherent;
 		};
 
-		ehci@40000 {
+		usb@40000 {
 			compatible = "snps,hsdk-v1.0-ehci", "generic-ehci";
 			reg = <0x40000 0x100>;
 			interrupts = <15>;
diff --git a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
index cbb179770293..90a412026e64 100644
--- a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
@@ -46,7 +46,7 @@ ethernet@18000 {
 			clock-names = "stmmaceth";
 		};
 
-		ehci@40000 {
+		usb@40000 {
 			compatible = "generic-ehci";
 			reg = < 0x40000 0x100 >;
 			interrupts = < 8 >;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH RESEND v9 2/5] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 14:16 [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
  2022-06-24 14:16 ` [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT " Serge Semin
@ 2022-06-24 14:16 ` Serge Semin
  2022-06-24 17:14   ` Krzysztof Kozlowski
  2022-06-24 17:19   ` (subset) " Krzysztof Kozlowski
  2022-06-24 14:16 ` [PATCH RESEND v9 3/5] powerpc: dts: akebono: " Serge Semin
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 14:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Felipe Balbi, Michael Ellerman,
	Vladimir Zapolskiy, Alexey Brodkin, Vineet Gupta, Rob Herring,
	Rob Herring, Greg Kroah-Hartman, Krzysztof Kozlowski, linux-usb,
	Krzysztof Kozlowski
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Serge Semin, Paul Mackerras, linux-arm-msm,
	linux-snps-arc, linuxppc-dev, linux-arm-kernel

In accordance with the Generic EHCI/OHCI bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
nodes are correctly named.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/lpc18xx.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi
index 10b8249b8ab6..82ffd7b0ad8a 100644
--- a/arch/arm/boot/dts/lpc18xx.dtsi
+++ b/arch/arm/boot/dts/lpc18xx.dtsi
@@ -121,7 +121,7 @@ mmcsd: mmcsd@40004000 {
 			status = "disabled";
 		};
 
-		usb0: ehci@40006100 {
+		usb0: usb@40006100 {
 			compatible = "nxp,lpc1850-ehci", "generic-ehci";
 			reg = <0x40006100 0x100>;
 			interrupts = <8>;
@@ -133,7 +133,7 @@ usb0: ehci@40006100 {
 			status = "disabled";
 		};
 
-		usb1: ehci@40007100 {
+		usb1: usb@40007100 {
 			compatible = "nxp,lpc1850-ehci", "generic-ehci";
 			reg = <0x40007100 0x100>;
 			interrupts = <9>;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH RESEND v9 3/5] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 14:16 [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
  2022-06-24 14:16 ` [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT " Serge Semin
  2022-06-24 14:16 ` [PATCH RESEND v9 2/5] arm: dts: lpc18xx: " Serge Semin
@ 2022-06-24 14:16 ` Serge Semin
  2022-06-24 14:16 ` [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 " Serge Semin
  2022-06-24 14:16 ` [PATCH RESEND v9 5/5] arm64: dts: apm: " Serge Semin
  4 siblings, 0 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 14:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Felipe Balbi, Michael Ellerman,
	Vladimir Zapolskiy, Alexey Brodkin, Vineet Gupta, Rob Herring,
	Rob Herring, Greg Kroah-Hartman, Krzysztof Kozlowski, linux-usb,
	Krzysztof Kozlowski, Benjamin Herrenschmidt, Paul Mackerras
  Cc: devicetree, Khuong Dinh, linux-arm-msm, Patrice Chotard,
	Serge Semin, linux-kernel, Serge Semin, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel

In accordance with the Generic EHCI/OHCI bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
nodes are correctly named.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/powerpc/boot/dts/akebono.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts
index df18f8dc4642..343326c30380 100644
--- a/arch/powerpc/boot/dts/akebono.dts
+++ b/arch/powerpc/boot/dts/akebono.dts
@@ -126,7 +126,7 @@ SATA0: sata@30000010000 {
 			interrupts = <93 2>;
 		};
 
-		EHCI0: ehci@30010000000 {
+		EHCI0: usb@30010000000 {
 			compatible = "ibm,476gtr-ehci", "generic-ehci";
 			reg = <0x300 0x10000000 0x0 0x10000>;
 			interrupt-parent = <&MPIC>;
@@ -140,14 +140,14 @@ SD0: sd@30000000000 {
 			interrupt-parent = <&MPIC>;
 		};
 
-		OHCI0: ohci@30010010000 {
+		OHCI0: usb@30010010000 {
 			compatible = "ibm,476gtr-ohci", "generic-ohci";
 			reg = <0x300 0x10010000 0x0 0x10000>;
 			interrupt-parent = <&MPIC>;
 			interrupts = <89 1>;
 			};
 
-		OHCI1: ohci@30010020000 {
+		OHCI1: usb@30010020000 {
 			compatible = "ibm,476gtr-ohci", "generic-ohci";
 			reg = <0x300 0x10020000 0x0 0x10000>;
 			interrupt-parent = <&MPIC>;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  2022-06-24 14:16 [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
                   ` (2 preceding siblings ...)
  2022-06-24 14:16 ` [PATCH RESEND v9 3/5] powerpc: dts: akebono: " Serge Semin
@ 2022-06-24 14:16 ` Serge Semin
  2022-06-24 17:18   ` Krzysztof Kozlowski
  2022-06-26 10:46   ` Krzysztof Kozlowski
  2022-06-24 14:16 ` [PATCH RESEND v9 5/5] arm64: dts: apm: " Serge Semin
  4 siblings, 2 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 14:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Felipe Balbi, Michael Ellerman,
	Vladimir Zapolskiy, Alexey Brodkin, Vineet Gupta, Rob Herring,
	Rob Herring, Greg Kroah-Hartman, Krzysztof Kozlowski, linux-usb,
	Patrice Chotard, Krzysztof Kozlowski
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Serge Semin, Paul Mackerras, linux-arm-msm,
	linux-snps-arc, linuxppc-dev, linux-arm-kernel

In accordance with the DWC USB3 bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
named.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
---
 arch/arm/boot/dts/stih407-family.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 1713f7878117..7ba528315dbe 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -725,7 +725,7 @@ st_dwc3: dwc3@8f94000 {
 
 			status = "disabled";
 
-			dwc3: dwc3@9900000 {
+			dwc3: usb@9900000 {
 				compatible	= "snps,dwc3";
 				reg		= <0x09900000 0x100000>;
 				interrupts	= <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
  2022-06-24 14:16 [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
                   ` (3 preceding siblings ...)
  2022-06-24 14:16 ` [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 " Serge Semin
@ 2022-06-24 14:16 ` Serge Semin
  2022-06-24 17:17   ` Krzysztof Kozlowski
  2022-06-26 10:50   ` (subset) " Krzysztof Kozlowski
  4 siblings, 2 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 14:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Felipe Balbi, Michael Ellerman,
	Vladimir Zapolskiy, Alexey Brodkin, Vineet Gupta, Rob Herring,
	Rob Herring, Greg Kroah-Hartman, Krzysztof Kozlowski, linux-usb,
	Khuong Dinh, Krzysztof Kozlowski
  Cc: devicetree, Patrice Chotard, Serge Semin, linux-kernel,
	Serge Semin, Paul Mackerras, linux-arm-msm, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel

In accordance with the DWC USB3 bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
named despite of the warning comment about possible backward
compatibility issues.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++--
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index a83c82c50e29..832dd85b00bd 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -597,8 +597,8 @@ serial0: serial@10600000 {
 			interrupts = <0x0 0x4c 0x4>;
 		};
 
-		/* Do not change dwusb name, coded for backward compatibility */
-		usb0: dwusb@19000000 {
+		/* Node-name might need to be coded as dwusb for backward compatibility */
+		usb0: usb@19000000 {
 			status = "disabled";
 			compatible = "snps,dwc3";
 			reg =  <0x0 0x19000000 0x0 0x100000>;
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 0f37e77f5459..1520a945b7f9 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -923,8 +923,8 @@ sata3: sata@1a800000 {
 			phy-names = "sata-phy";
 		};
 
-		/* Do not change dwusb name, coded for backward compatibility */
-		usb0: dwusb@19000000 {
+		/* Node-name might need to be coded as dwusb for backward compatibility */
+		usb0: usb@19000000 {
 			status = "disabled";
 			compatible = "snps,dwc3";
 			reg =  <0x0 0x19000000 0x0 0x100000>;
@@ -933,7 +933,7 @@ usb0: dwusb@19000000 {
 			dr_mode = "host";
 		};
 
-		usb1: dwusb@19800000 {
+		usb1: usb@19800000 {
 			status = "disabled";
 			compatible = "snps,dwc3";
 			reg =  <0x0 0x19800000 0x0 0x100000>;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 2/5] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 2/5] arm: dts: lpc18xx: " Serge Semin
@ 2022-06-24 17:14   ` Krzysztof Kozlowski
  2022-06-24 20:41     ` Serge Semin
  2022-06-24 17:19   ` (subset) " Krzysztof Kozlowski
  1 sibling, 1 reply; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-24 17:14 UTC (permalink / raw)
  To: Serge Semin, Andy Gross, Bjorn Andersson, Felipe Balbi,
	Michael Ellerman, Vladimir Zapolskiy, Alexey Brodkin,
	Vineet Gupta, Rob Herring, Rob Herring, Greg Kroah-Hartman,
	Krzysztof Kozlowski, linux-usb, Krzysztof Kozlowski
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Paul Mackerras, linux-arm-msm, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel

On 24/06/2022 16:16, Serge Semin wrote:
> In accordance with the Generic EHCI/OHCI bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
> nodes are correctly named.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm/boot/dts/lpc18xx.dtsi | 4 ++--

You should split the patchset per architecture, because maybe that's why
no one picks it up?

Let me pick up ARM bits through my cleanup series. If anyone objects,
please let me know.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 5/5] arm64: dts: apm: " Serge Semin
@ 2022-06-24 17:17   ` Krzysztof Kozlowski
  2022-06-24 20:59     ` Serge Semin
  2022-06-26 10:50   ` (subset) " Krzysztof Kozlowski
  1 sibling, 1 reply; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-24 17:17 UTC (permalink / raw)
  To: Serge Semin, Andy Gross, Bjorn Andersson, Felipe Balbi,
	Michael Ellerman, Vladimir Zapolskiy, Alexey Brodkin,
	Vineet Gupta, Rob Herring, Rob Herring, Greg Kroah-Hartman,
	Krzysztof Kozlowski, linux-usb, Khuong Dinh, Krzysztof Kozlowski
  Cc: devicetree, Patrice Chotard, Serge Semin, linux-kernel,
	Paul Mackerras, linux-arm-msm, linux-snps-arc, linuxppc-dev,
	linux-arm-kernel

On 24/06/2022 16:16, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> named despite of the warning comment about possible backward
> compatibility issues.

Sometimes node name is exposed to user-space which depends on it. How
did you check there is no issue here?

> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++--
>  arch/arm64/boot/dts/apm/apm-storm.dtsi     | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> index a83c82c50e29..832dd85b00bd 100644
> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> @@ -597,8 +597,8 @@ serial0: serial@10600000 {
>  			interrupts = <0x0 0x4c 0x4>;
>  		};
>  
> -		/* Do not change dwusb name, coded for backward compatibility */
> -		usb0: dwusb@19000000 {
> +		/* Node-name might need to be coded as dwusb for backward compatibility */
> +		usb0: usb@19000000 {
>  			status = "disabled";
>  			compatible = "snps,dwc3";
>  			reg =  <0x0 0x19000000 0x0 0x100000>;
> diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> index 0f37e77f5459..1520a945b7f9 100644
> --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
> +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> @@ -923,8 +923,8 @@ sata3: sata@1a800000 {
>  			phy-names = "sata-phy";
>  		};
>  
> -		/* Do not change dwusb name, coded for backward compatibility */
> -		usb0: dwusb@19000000 {
> +		/* Node-name might need to be coded as dwusb for backward compatibility */
> +		usb0: usb@19000000 {
>  			status = "disabled";
>  			compatible = "snps,dwc3";
>  			reg =  <0x0 0x19000000 0x0 0x100000>;
> @@ -933,7 +933,7 @@ usb0: dwusb@19000000 {
>  			dr_mode = "host";
>  		};
>  
> -		usb1: dwusb@19800000 {
> +		usb1: usb@19800000 {
>  			status = "disabled";
>  			compatible = "snps,dwc3";
>  			reg =  <0x0 0x19800000 0x0 0x100000>;


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 " Serge Semin
@ 2022-06-24 17:18   ` Krzysztof Kozlowski
  2022-06-24 20:45     ` Serge Semin
  2022-06-26 10:46   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-24 17:18 UTC (permalink / raw)
  To: Serge Semin, Andy Gross, Bjorn Andersson, Felipe Balbi,
	Michael Ellerman, Vladimir Zapolskiy, Alexey Brodkin,
	Vineet Gupta, Rob Herring, Rob Herring, Greg Kroah-Hartman,
	Krzysztof Kozlowski, linux-usb, Patrice Chotard,
	Krzysztof Kozlowski
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Paul Mackerras, linux-arm-msm, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel

On 24/06/2022 16:16, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> named.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 1713f7878117..7ba528315dbe 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -725,7 +725,7 @@ st_dwc3: dwc3@8f94000 {
>  
>  			status = "disabled";
>  
> -			dwc3: dwc3@9900000 {
> +			dwc3: usb@9900000 {

This does not apply. What tree is it based on?


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: (subset) [PATCH RESEND v9 2/5] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 2/5] arm: dts: lpc18xx: " Serge Semin
  2022-06-24 17:14   ` Krzysztof Kozlowski
@ 2022-06-24 17:19   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-24 17:19 UTC (permalink / raw)
  To: gregkh, mpe, abrodkin, agross, robh, vz, Sergey.Semin,
	bjorn.andersson, linux-usb, balbi, vgupta, krzk,
	krzysztof.kozlowski+dt, robh+dt
  Cc: devicetree, khuong, linux-arm-msm, patrice.chotard,
	fancer.lancer, linux-kernel, Krzysztof Kozlowski, paulus,
	linux-snps-arc, linuxppc-dev, linux-arm-kernel

On Fri, 24 Jun 2022 17:16:18 +0300, Serge Semin wrote:
> In accordance with the Generic EHCI/OHCI bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
> nodes are correctly named.
> 
> 
> [...]

Applied, thanks!

[2/5] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name
      https://git.kernel.org/krzk/linux/c/986fd5fe55cb369c34a1dc65b1469aac536a6d50

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 2/5] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 17:14   ` Krzysztof Kozlowski
@ 2022-06-24 20:41     ` Serge Semin
  0 siblings, 0 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 20:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, devicetree, linux-arm-msm,
	Vladimir Zapolskiy, Rob Herring, linux-arm-kernel, Felipe Balbi,
	Greg Kroah-Hartman, linux-usb, Patrice Chotard, linux-kernel,
	Serge Semin, Vineet Gupta, linuxppc-dev

On Fri, Jun 24, 2022 at 07:14:44PM +0200, Krzysztof Kozlowski wrote:
> On 24/06/2022 16:16, Serge Semin wrote:
> > In accordance with the Generic EHCI/OHCI bindings the corresponding node
> > name is suppose to comply with the Generic USB HCD DT schema, which
> > requires the USB nodes to have the name acceptable by the regexp:
> > "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
> > nodes are correctly named.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  arch/arm/boot/dts/lpc18xx.dtsi | 4 ++--
> 

> You should split the patchset per architecture, because maybe that's why
> no one picks it up?

Each patch is sent out to the corresponding mailing list and the
maintainers. I don't think splitting the patchset into the subsets will
be more efficient especially seeing the initial patchset consisted of
30 patches of which only five left.

I was very busy last year with another activities so what was left of this
patchset was stalling on my local repo all that time. I have been very
surprised to realise that the submitted part still hasn't been merged in for
all that time. So I've got back to resubmitting the series.

* Though the Qualcom dts have been fixed by you lately.

> 
> Let me pick up ARM bits through my cleanup series. If anyone objects,
> please let me know.

Ok. Thanks.

-Sergey

> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  2022-06-24 17:18   ` Krzysztof Kozlowski
@ 2022-06-24 20:45     ` Serge Semin
  2022-06-26 10:42       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 20+ messages in thread
From: Serge Semin @ 2022-06-24 20:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, Patrice Chotard, devicetree,
	linux-arm-msm, Vladimir Zapolskiy, Rob Herring, linux-arm-kernel,
	Felipe Balbi, Greg Kroah-Hartman, linux-usb, Patrice Chotard,
	linux-kernel, Serge Semin, Vineet Gupta, linuxppc-dev

On Fri, Jun 24, 2022 at 07:18:57PM +0200, Krzysztof Kozlowski wrote:
> On 24/06/2022 16:16, Serge Semin wrote:
> > In accordance with the DWC USB3 bindings the corresponding node
> > name is suppose to comply with the Generic USB HCD DT schema, which
> > requires the USB nodes to have the name acceptable by the regexp:
> > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> > named.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
> > ---
> >  arch/arm/boot/dts/stih407-family.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> > index 1713f7878117..7ba528315dbe 100644
> > --- a/arch/arm/boot/dts/stih407-family.dtsi
> > +++ b/arch/arm/boot/dts/stih407-family.dtsi
> > @@ -725,7 +725,7 @@ st_dwc3: dwc3@8f94000 {
> >  
> >  			status = "disabled";
> >  
> > -			dwc3: dwc3@9900000 {
> > +			dwc3: usb@9900000 {
> 

> This does not apply. What tree is it based on?

That's weird. The series has been rebased onto the mainline kernel v5.19-rc3.
Do you have the stih407 dtsi fixed on your local repo?

-Sergey

> 
> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
  2022-06-24 17:17   ` Krzysztof Kozlowski
@ 2022-06-24 20:59     ` Serge Semin
  2022-06-26 10:49       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 20+ messages in thread
From: Serge Semin @ 2022-06-24 20:59 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, devicetree, linux-arm-msm,
	Vladimir Zapolskiy, Rob Herring, linux-arm-kernel, Felipe Balbi,
	Greg Kroah-Hartman, linux-usb, Patrice Chotard, linux-kernel,
	Serge Semin, Vineet Gupta, linuxppc-dev

On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote:
> On 24/06/2022 16:16, Serge Semin wrote:
> > In accordance with the DWC USB3 bindings the corresponding node
> > name is suppose to comply with the Generic USB HCD DT schema, which
> > requires the USB nodes to have the name acceptable by the regexp:
> > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> > named despite of the warning comment about possible backward
> > compatibility issues.
> 

> Sometimes node name is exposed to user-space which depends on it. How
> did you check there is no issue here?

I well remember the Qcom problem caused by one of my patch:
https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/

The next patch caused the same problem, but hasn't been reverted.
https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/

As before I am more inclined to thinking that the problem was mainly caused
by the improper node-name utilization. Anyway John later noted that the
problem was fixed in the user-space. That why afterwards you were able
to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3
node names and unit addresses").

Anyway I am not able to track the way the node-name is used on the
affected platform and can't make sure that the dts would be still
working well on that devices. But seeing nobody responded/commented on
this patch for more than a year we can at least try to merge this in
and see whether it causes any problem should the denoted platform is
still in use. If it does we can revert the update back and forget
about it.

-Sergey

> 
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++--
> >  arch/arm64/boot/dts/apm/apm-storm.dtsi     | 6 +++---
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> > index a83c82c50e29..832dd85b00bd 100644
> > --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> > +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> > @@ -597,8 +597,8 @@ serial0: serial@10600000 {
> >  			interrupts = <0x0 0x4c 0x4>;
> >  		};
> >  
> > -		/* Do not change dwusb name, coded for backward compatibility */
> > -		usb0: dwusb@19000000 {
> > +		/* Node-name might need to be coded as dwusb for backward compatibility */
> > +		usb0: usb@19000000 {
> >  			status = "disabled";
> >  			compatible = "snps,dwc3";
> >  			reg =  <0x0 0x19000000 0x0 0x100000>;
> > diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> > index 0f37e77f5459..1520a945b7f9 100644
> > --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
> > +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
> > @@ -923,8 +923,8 @@ sata3: sata@1a800000 {
> >  			phy-names = "sata-phy";
> >  		};
> >  
> > -		/* Do not change dwusb name, coded for backward compatibility */
> > -		usb0: dwusb@19000000 {
> > +		/* Node-name might need to be coded as dwusb for backward compatibility */
> > +		usb0: usb@19000000 {
> >  			status = "disabled";
> >  			compatible = "snps,dwc3";
> >  			reg =  <0x0 0x19000000 0x0 0x100000>;
> > @@ -933,7 +933,7 @@ usb0: dwusb@19000000 {
> >  			dr_mode = "host";
> >  		};
> >  
> > -		usb1: dwusb@19800000 {
> > +		usb1: usb@19800000 {
> >  			status = "disabled";
> >  			compatible = "snps,dwc3";
> >  			reg =  <0x0 0x19800000 0x0 0x100000>;
> 
> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT " Serge Semin
@ 2022-06-24 22:11   ` Vineet Gupta
  2022-06-24 22:28     ` Serge Semin
  0 siblings, 1 reply; 20+ messages in thread
From: Vineet Gupta @ 2022-06-24 22:11 UTC (permalink / raw)
  To: Serge Semin, Andy Gross, Bjorn Andersson, Felipe Balbi,
	Michael Ellerman, Vladimir Zapolskiy, Alexey Brodkin,
	Vineet Gupta, Rob Herring, Rob Herring, Greg Kroah-Hartman,
	Krzysztof Kozlowski, linux-usb, Krzysztof Kozlowski,
	Vineet Gupta
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Paul Mackerras, linux-arm-msm, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel


On 6/24/22 07:16, Serge Semin wrote:
> In accordance with the Generic EHCI/OHCI bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?"  . Make sure the "generic-ehci" and "generic-ohci"-compatible
> nodes are correctly named.
>
> Signed-off-by: Serge Semin<Sergey.Semin@baikalelectronics.ru>
> Acked-by: Alexey Brodkin<abrodkin@synopsys.com>
> Acked-by: Krzysztof Kozlowski<krzk@kernel.org>

This slipped thru cracks. Now on for-curr.

Thx,
-Vineet

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT nodes name
  2022-06-24 22:11   ` Vineet Gupta
@ 2022-06-24 22:28     ` Serge Semin
  0 siblings, 0 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-24 22:28 UTC (permalink / raw)
  To: Vineet Gupta
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, devicetree, linux-arm-msm,
	Vladimir Zapolskiy, Rob Herring, linux-arm-kernel, Felipe Balbi,
	Greg Kroah-Hartman, linux-usb, Patrice Chotard, linux-kernel,
	Serge Semin, Vineet Gupta, linuxppc-dev

On Fri, Jun 24, 2022 at 03:11:43PM -0700, Vineet Gupta wrote:
> 
> On 6/24/22 07:16, Serge Semin wrote:
> > In accordance with the Generic EHCI/OHCI bindings the corresponding node
> > name is suppose to comply with the Generic USB HCD DT schema, which
> > requires the USB nodes to have the name acceptable by the regexp:
> > "^usb(@.*)?"  . Make sure the "generic-ehci" and "generic-ohci"-compatible
> > nodes are correctly named.
> > 
> > Signed-off-by: Serge Semin<Sergey.Semin@baikalelectronics.ru>
> > Acked-by: Alexey Brodkin<abrodkin@synopsys.com>
> > Acked-by: Krzysztof Kozlowski<krzk@kernel.org>
> 

> This slipped thru cracks. Now on for-curr.

Great! Thanks.

-Sergey

> 
> Thx,
> -Vineet

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  2022-06-24 20:45     ` Serge Semin
@ 2022-06-26 10:42       ` Krzysztof Kozlowski
  2022-06-27 21:55         ` Serge Semin
  0 siblings, 1 reply; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-26 10:42 UTC (permalink / raw)
  To: Serge Semin
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, Patrice Chotard, devicetree,
	linux-arm-msm, Vladimir Zapolskiy, Rob Herring, linux-arm-kernel,
	Felipe Balbi, Greg Kroah-Hartman, linux-usb, Patrice Chotard,
	linux-kernel, Serge Semin, Vineet Gupta, linuxppc-dev

On 24/06/2022 22:45, Serge Semin wrote:
> On Fri, Jun 24, 2022 at 07:18:57PM +0200, Krzysztof Kozlowski wrote:
>> On 24/06/2022 16:16, Serge Semin wrote:
>>> In accordance with the DWC USB3 bindings the corresponding node
>>> name is suppose to comply with the Generic USB HCD DT schema, which
>>> requires the USB nodes to have the name acceptable by the regexp:
>>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
>>> named.
>>>
>>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>>> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
>>> ---
>>>  arch/arm/boot/dts/stih407-family.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
>>> index 1713f7878117..7ba528315dbe 100644
>>> --- a/arch/arm/boot/dts/stih407-family.dtsi
>>> +++ b/arch/arm/boot/dts/stih407-family.dtsi
>>> @@ -725,7 +725,7 @@ st_dwc3: dwc3@8f94000 {
>>>  
>>>  			status = "disabled";
>>>  
>>> -			dwc3: dwc3@9900000 {
>>> +			dwc3: usb@9900000 {
>>
> 
>> This does not apply. What tree is it based on?
> 
> That's weird. The series has been rebased onto the mainline kernel v5.19-rc3.
> Do you have the stih407 dtsi fixed on your local repo?

It conflicts with my change:
https://lore.kernel.org/all/20220526203632.831039-1-krzysztof.kozlowski@linaro.org/

I'll apply with local fixups.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 " Serge Semin
  2022-06-24 17:18   ` Krzysztof Kozlowski
@ 2022-06-26 10:46   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-26 10:46 UTC (permalink / raw)
  To: Serge Semin, Andy Gross, Bjorn Andersson, Felipe Balbi,
	Michael Ellerman, Vladimir Zapolskiy, Alexey Brodkin,
	Vineet Gupta, Rob Herring, Rob Herring, Greg Kroah-Hartman,
	Krzysztof Kozlowski, linux-usb, Patrice Chotard,
	Krzysztof Kozlowski
  Cc: devicetree, Khuong Dinh, Patrice Chotard, Serge Semin,
	linux-kernel, Paul Mackerras, linux-arm-msm, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel

On 24/06/2022 16:16, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> named.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks, applied.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
  2022-06-24 20:59     ` Serge Semin
@ 2022-06-26 10:49       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-26 10:49 UTC (permalink / raw)
  To: Serge Semin
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, devicetree, linux-arm-msm,
	Vladimir Zapolskiy, Rob Herring, linux-arm-kernel, Felipe Balbi,
	Greg Kroah-Hartman, linux-usb, Patrice Chotard, linux-kernel,
	Serge Semin, Vineet Gupta, linuxppc-dev

On 24/06/2022 22:59, Serge Semin wrote:
> On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote:
>> On 24/06/2022 16:16, Serge Semin wrote:
>>> In accordance with the DWC USB3 bindings the corresponding node
>>> name is suppose to comply with the Generic USB HCD DT schema, which
>>> requires the USB nodes to have the name acceptable by the regexp:
>>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
>>> named despite of the warning comment about possible backward
>>> compatibility issues.
>>
> 
>> Sometimes node name is exposed to user-space which depends on it. How
>> did you check there is no issue here?
> 
> I well remember the Qcom problem caused by one of my patch:
> https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/
> 
> The next patch caused the same problem, but hasn't been reverted.
> https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/
> 
> As before I am more inclined to thinking that the problem was mainly caused
> by the improper node-name utilization. Anyway John later noted that the
> problem was fixed in the user-space. 

Yes, I remember. The node names are not considered ABI, therefore any
reliance on them is not correct.

I wonder however what was the reasoning for this comment in APM DTS.

> That why afterwards you were able
> to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3
> node names and unit addresses").
> 
> Anyway I am not able to track the way the node-name is used on the
> affected platform and can't make sure that the dts would be still
> working well on that devices. But seeing nobody responded/commented on
> this patch for more than a year we can at least try to merge this in
> and see whether it causes any problem should the denoted platform is
> still in use. If it does we can revert the update back and forget
> about it.

The APM is kind of abandoned, so indeed we might never get a reply.

I'll take it.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: (subset) [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
  2022-06-24 14:16 ` [PATCH RESEND v9 5/5] arm64: dts: apm: " Serge Semin
  2022-06-24 17:17   ` Krzysztof Kozlowski
@ 2022-06-26 10:50   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-26 10:50 UTC (permalink / raw)
  To: bjorn.andersson, mpe, vz, robh, abrodkin, krzysztof.kozlowski+dt,
	robh+dt, krzk, balbi, Sergey.Semin, agross, gregkh, vgupta,
	khuong, linux-usb
  Cc: devicetree, linux-arm-msm, linux-kernel, fancer.lancer,
	patrice.chotard, Krzysztof Kozlowski, paulus, linux-snps-arc,
	linuxppc-dev, linux-arm-kernel

On Fri, 24 Jun 2022 17:16:21 +0300, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> named despite of the warning comment about possible backward
> compatibility issues.
> 
> [...]

Applied, thanks!

[5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name
      https://git.kernel.org/krzk/linux/c/fcf036a017b251d362559cf7eb0bb6e614ccf842

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name
  2022-06-26 10:42       ` Krzysztof Kozlowski
@ 2022-06-27 21:55         ` Serge Semin
  0 siblings, 0 replies; 20+ messages in thread
From: Serge Semin @ 2022-06-27 21:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Paul Mackerras, Krzysztof Kozlowski,
	Rob Herring, Khuong Dinh, Alexey Brodkin, Krzysztof Kozlowski,
	Andy Gross, linux-snps-arc, Patrice Chotard, devicetree,
	linux-arm-msm, Vladimir Zapolskiy, Rob Herring, linux-arm-kernel,
	Felipe Balbi, Greg Kroah-Hartman, linux-usb, Patrice Chotard,
	linux-kernel, Serge Semin, Vineet Gupta, linuxppc-dev

On Sun, Jun 26, 2022 at 12:42:48PM +0200, Krzysztof Kozlowski wrote:
> On 24/06/2022 22:45, Serge Semin wrote:
> > On Fri, Jun 24, 2022 at 07:18:57PM +0200, Krzysztof Kozlowski wrote:
> >> On 24/06/2022 16:16, Serge Semin wrote:
> >>> In accordance with the DWC USB3 bindings the corresponding node
> >>> name is suppose to comply with the Generic USB HCD DT schema, which
> >>> requires the USB nodes to have the name acceptable by the regexp:
> >>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly
> >>> named.
> >>>
> >>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >>> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>> Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
> >>> ---
> >>>  arch/arm/boot/dts/stih407-family.dtsi | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> >>> index 1713f7878117..7ba528315dbe 100644
> >>> --- a/arch/arm/boot/dts/stih407-family.dtsi
> >>> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> >>> @@ -725,7 +725,7 @@ st_dwc3: dwc3@8f94000 {
> >>>  
> >>>  			status = "disabled";
> >>>  
> >>> -			dwc3: dwc3@9900000 {
> >>> +			dwc3: usb@9900000 {
> >>
> > 
> >> This does not apply. What tree is it based on?
> > 
> > That's weird. The series has been rebased onto the mainline kernel v5.19-rc3.
> > Do you have the stih407 dtsi fixed on your local repo?
> 

> It conflicts with my change:
> https://lore.kernel.org/all/20220526203632.831039-1-krzysztof.kozlowski@linaro.org/
> 
> I'll apply with local fixups.

Ok. Thanks.

-Sergey

> 
> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-06-27 21:55 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 14:16 [PATCH RESEND v9 0/5] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Serge Semin
2022-06-24 14:16 ` [PATCH RESEND v9 1/5] arc: dts: Harmonize EHCI/OHCI DT " Serge Semin
2022-06-24 22:11   ` Vineet Gupta
2022-06-24 22:28     ` Serge Semin
2022-06-24 14:16 ` [PATCH RESEND v9 2/5] arm: dts: lpc18xx: " Serge Semin
2022-06-24 17:14   ` Krzysztof Kozlowski
2022-06-24 20:41     ` Serge Semin
2022-06-24 17:19   ` (subset) " Krzysztof Kozlowski
2022-06-24 14:16 ` [PATCH RESEND v9 3/5] powerpc: dts: akebono: " Serge Semin
2022-06-24 14:16 ` [PATCH RESEND v9 4/5] arm: dts: stih407-family: Harmonize DWC USB3 " Serge Semin
2022-06-24 17:18   ` Krzysztof Kozlowski
2022-06-24 20:45     ` Serge Semin
2022-06-26 10:42       ` Krzysztof Kozlowski
2022-06-27 21:55         ` Serge Semin
2022-06-26 10:46   ` Krzysztof Kozlowski
2022-06-24 14:16 ` [PATCH RESEND v9 5/5] arm64: dts: apm: " Serge Semin
2022-06-24 17:17   ` Krzysztof Kozlowski
2022-06-24 20:59     ` Serge Semin
2022-06-26 10:49       ` Krzysztof Kozlowski
2022-06-26 10:50   ` (subset) " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).