linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: 44x: Add of_node_put() when break out from for_each
@ 2022-07-01 13:31 Liang He
  2022-09-09 12:07 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-07-01 13:31 UTC (permalink / raw)
  To: mpe, benh, paulus, windhl, linuxppc-dev

In ppc47x_init_irq(), we need to call of_node_put() when there is
a break during the iteration of for_each_node_with_property() which
will automatically increase and decrease the refcount.

Signed-off-by: Liang He <windhl@126.com>
---
 arch/powerpc/platforms/44x/ppc476.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/ppc476.c b/arch/powerpc/platforms/44x/ppc476.c
index 20cc8f80b086..7d9075fb20c9 100644
--- a/arch/powerpc/platforms/44x/ppc476.c
+++ b/arch/powerpc/platforms/44x/ppc476.c
@@ -140,6 +140,7 @@ static void __init ppc47x_init_irq(void)
 		ppc_md.get_irq = mpic_get_irq;
 	} else
 		panic("Unrecognized top level interrupt controller");
+	of_node_put(np);
 }
 
 #ifdef CONFIG_SMP
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc: 44x: Add of_node_put() when break out from for_each
  2022-07-01 13:31 [PATCH] powerpc: 44x: Add of_node_put() when break out from for_each Liang He
@ 2022-09-09 12:07 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-09-09 12:07 UTC (permalink / raw)
  To: linuxppc-dev, paulus, Liang He, benh, mpe

On Fri, 1 Jul 2022 21:31:26 +0800, Liang He wrote:
> In ppc47x_init_irq(), we need to call of_node_put() when there is
> a break during the iteration of for_each_node_with_property() which
> will automatically increase and decrease the refcount.
> 
> 

Applied to powerpc/next.

[1/1] powerpc: 44x: Add of_node_put() when break out from for_each
      https://git.kernel.org/powerpc/c/9d86f0919544d8e422be2a1d562de1dbbbb6052d

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-09 12:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-01 13:31 [PATCH] powerpc: 44x: Add of_node_put() when break out from for_each Liang He
2022-09-09 12:07 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).