[PATCH] pseries/mobility: reset the RCU watchdogs after a LPM

[PATCH] pseries/mobility: reset the RCU watchdogs after a LPM

[Laurent Dufour]

The RCU watchdog timer should be reset when restarting the CPU after a Live
Partition Mobility operation.

Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/mobility.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index 634fac5db3f9..9e10f38dd9ad 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -636,8 +636,10 @@ static int do_join(void *arg)
 	}
 	/*
 	 * Execution may have been suspended for several seconds, so
-	 * reset the watchdog.
+	 * reset the watchdogs.
 	 */
+	rcu_cpu_stall_reset();
+	/* touch_nmi_watchdog() also touch the soft lockup watchdog */
 	touch_nmi_watchdog();
 	return ret;
 }
-- 
2.38.1

Re: [PATCH] pseries/mobility: reset the RCU watchdogs after a LPM

[Nicholas Piggin]

On Sat Nov 26, 2022 at 3:32 AM AEST, Laurent Dufour wrote:
> The RCU watchdog timer should be reset when restarting the CPU after a Live
> Partition Mobility operation.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>

Looks okay to me. xmon touches the softlockup watchdog explicitly but
is that for architectures with unsynchronized clocks maybe.

Acked-by: Nicholas Piggin <npiggin@gmail.com>

> ---
>  arch/powerpc/platforms/pseries/mobility.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
> index 634fac5db3f9..9e10f38dd9ad 100644
> --- a/arch/powerpc/platforms/pseries/mobility.c
> +++ b/arch/powerpc/platforms/pseries/mobility.c
> @@ -636,8 +636,10 @@ static int do_join(void *arg)
>  	}
>  	/*
>  	 * Execution may have been suspended for several seconds, so
> -	 * reset the watchdog.
> +	 * reset the watchdogs.
>  	 */
> +	rcu_cpu_stall_reset();
> +	/* touch_nmi_watchdog() also touch the soft lockup watchdog */
>  	touch_nmi_watchdog();
>  	return ret;
>  }
> -- 
> 2.38.1

Re: [PATCH] pseries/mobility: reset the RCU watchdogs after a LPM

[Michael Ellerman]

On Fri, 25 Nov 2022 18:32:04 +0100, Laurent Dufour wrote:
> The RCU watchdog timer should be reset when restarting the CPU after a Live
> Partition Mobility operation.
> 
> 

Applied to powerpc/next.

[1/1] pseries/mobility: reset the RCU watchdogs after a LPM
      https://git.kernel.org/powerpc/c/9b574cfab7d4e68c67c4ee4fcde912ef54a25b88

cheers