From: Michael Ellerman <mpe@ellerman.id.au>
To: <linuxppc-dev@lists.ozlabs.org>
Cc: arnd@arndb.de
Subject: [PATCH 1/5] powerpc/suspend: Add prototype for do_after_copyback()
Date: Thu, 30 Nov 2023 00:19:15 +1100 [thread overview]
Message-ID: <20231129131919.2528517-1-mpe@ellerman.id.au> (raw)
With HIBERNATION=y the build breaks with:
arch/powerpc/kernel/swsusp_64.c:14:6: error: no previous prototype for ‘do_after_copyback’ [-Werror=missing-prototypes]
14 | void do_after_copyback(void)
| ^~~~~~~~~~~~~~~~~
do_after_copyback() is only called from asm, so there is no prototype,
nor any header where it makes sense to place one. Just add a prototype
in the C file to fix the build error.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/kernel/swsusp_64.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/swsusp_64.c b/arch/powerpc/kernel/swsusp_64.c
index 16ee3baaf09a..50fa8fc9ef95 100644
--- a/arch/powerpc/kernel/swsusp_64.c
+++ b/arch/powerpc/kernel/swsusp_64.c
@@ -11,6 +11,8 @@
#include <linux/interrupt.h>
#include <linux/nmi.h>
+void do_after_copyback(void);
+
void do_after_copyback(void)
{
iommu_restore();
--
2.41.0
next reply other threads:[~2023-11-29 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:19 Michael Ellerman [this message]
2023-11-29 13:19 ` [PATCH 2/5] powerpc/512x: Make pdm360ng_init() static Michael Ellerman
2023-11-29 13:19 ` [PATCH 3/5] powerpc/512x: Fix missing prototype warnings Michael Ellerman
2023-11-29 13:19 ` [PATCH 4/5] powerpc/44x: Make ppc44x_idle_init() static Michael Ellerman
2023-11-29 13:19 ` [PATCH 5/5] powerpc/64s: Fix CONFIG_NUMA=n build Michael Ellerman
2023-11-29 13:25 ` Arnd Bergmann
2023-11-30 6:43 ` Michael Ellerman
2023-11-30 8:07 ` Arnd Bergmann
2023-11-29 13:40 ` [PATCH 1/5] powerpc/suspend: Add prototype for do_after_copyback() Arnd Bergmann
2023-12-07 12:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129131919.2528517-1-mpe@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).