From: "Arnd Bergmann" <arnd@arndb.de>
To: "Michael Ellerman" <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/5] powerpc/64s: Fix CONFIG_NUMA=n build
Date: Thu, 30 Nov 2023 09:07:59 +0100 [thread overview]
Message-ID: <462cf182-2d46-4a6d-86bc-f8b54e787a49@app.fastmail.com> (raw)
In-Reply-To: <87v89j212y.fsf@mail.lhotse>
On Thu, Nov 30, 2023, at 07:43, Michael Ellerman wrote:
> "Arnd Bergmann" <arnd@arndb.de> writes:
>> On Wed, Nov 29, 2023, at 14:19, Michael Ellerman wrote:
>>> diff --git a/arch/powerpc/mm/mmu_decl.h b/arch/powerpc/mm/mmu_decl.h
>>> index 7f9ff0640124..72341b9fb552 100644
>>> --- a/arch/powerpc/mm/mmu_decl.h
>>> +++ b/arch/powerpc/mm/mmu_decl.h
>>> +
>>> +#ifdef CONFIG_MEMORY_HOTPLUG
>>> +int create_section_mapping(unsigned long start, unsigned long end,
>>> + int nid, pgprot_t prot);
>>> +#endif
>>
>> This one should probably go next to the remove_section_mapping()
>> declaration in arch/powerpc/include/asm/sparsemem.h for consistency.
>
> That doesn't work due to:
>
> In file included from ../include/linux/numa.h:26,
> from ../include/linux/async.h:13,
> from ../init/initramfs.c:3:
> ../arch/powerpc/include/asm/sparsemem.h:19:44: error: unknown type name
> ‘pgprot_t’
> 19 | int nid, pgprot_t prot);
> | ^~~~~~~~
>
> Which might be fixable, but I'd rather just move
> remove_section_mapping() into mmu_decl.h as well.
Ok, makes sense.
Arnd
next prev parent reply other threads:[~2023-11-30 8:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:19 [PATCH 1/5] powerpc/suspend: Add prototype for do_after_copyback() Michael Ellerman
2023-11-29 13:19 ` [PATCH 2/5] powerpc/512x: Make pdm360ng_init() static Michael Ellerman
2023-11-29 13:19 ` [PATCH 3/5] powerpc/512x: Fix missing prototype warnings Michael Ellerman
2023-11-29 13:19 ` [PATCH 4/5] powerpc/44x: Make ppc44x_idle_init() static Michael Ellerman
2023-11-29 13:19 ` [PATCH 5/5] powerpc/64s: Fix CONFIG_NUMA=n build Michael Ellerman
2023-11-29 13:25 ` Arnd Bergmann
2023-11-30 6:43 ` Michael Ellerman
2023-11-30 8:07 ` Arnd Bergmann [this message]
2023-11-29 13:40 ` [PATCH 1/5] powerpc/suspend: Add prototype for do_after_copyback() Arnd Bergmann
2023-12-07 12:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462cf182-2d46-4a6d-86bc-f8b54e787a49@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).