* [PATCH] powerpc: Fix 64K page size support for PPC44x
@ 2013-10-17 5:15 Alistair Popple
2013-10-17 5:25 ` Aneesh Kumar K.V
0 siblings, 1 reply; 3+ messages in thread
From: Alistair Popple @ 2013-10-17 5:15 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Alistair Popple, aneesh.kumar
PPC44x supports page sizes other than 4K however when 64K page sizes
are selected compilation fails. This is due to a change in the
definition of pgtable_t introduced by the following patch:
commit 5c1f6ee9a31cbdac90bbb8ae1ba4475031ac74b4
Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
powerpc: Reduce PTE table memory wastage
The above patch only implements the new layout for PPC64 so it doesn't
compile for PPC32 with a 64K page size. Ideally we should implement
the same layout for PPC32 however for the meantime this patch reverts
the definition of pgtable_t for PPC32.
Signed-off-by: Alistair Popple <alistair@popple.id.au>
---
arch/powerpc/include/asm/page.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
index b9f4262..b142d58 100644
--- a/arch/powerpc/include/asm/page.h
+++ b/arch/powerpc/include/asm/page.h
@@ -403,7 +403,7 @@ void arch_free_page(struct page *page, int order);
struct vm_area_struct;
-#ifdef CONFIG_PPC_64K_PAGES
+#if defined(CONFIG_PPC_64K_PAGES) && defined(PPC64)
typedef pte_t *pgtable_t;
#else
typedef struct page *pgtable_t;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix 64K page size support for PPC44x
2013-10-17 5:15 [PATCH] powerpc: Fix 64K page size support for PPC44x Alistair Popple
@ 2013-10-17 5:25 ` Aneesh Kumar K.V
2013-10-17 5:47 ` Alistair Popple
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2013-10-17 5:25 UTC (permalink / raw)
To: Alistair Popple, linuxppc-dev; +Cc: Alistair Popple
Alistair Popple <alistair@popple.id.au> writes:
> PPC44x supports page sizes other than 4K however when 64K page sizes
> are selected compilation fails. This is due to a change in the
> definition of pgtable_t introduced by the following patch:
>
> commit 5c1f6ee9a31cbdac90bbb8ae1ba4475031ac74b4
> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> powerpc: Reduce PTE table memory wastage
>
> The above patch only implements the new layout for PPC64 so it doesn't
> compile for PPC32 with a 64K page size. Ideally we should implement
> the same layout for PPC32 however for the meantime this patch reverts
> the definition of pgtable_t for PPC32.
>
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
> ---
> arch/powerpc/include/asm/page.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
> index b9f4262..b142d58 100644
> --- a/arch/powerpc/include/asm/page.h
> +++ b/arch/powerpc/include/asm/page.h
> @@ -403,7 +403,7 @@ void arch_free_page(struct page *page, int order);
>
> struct vm_area_struct;
>
> -#ifdef CONFIG_PPC_64K_PAGES
> +#if defined(CONFIG_PPC_64K_PAGES) && defined(PPC64)
^^^ CONFIG_PPC64 ?
> typedef pte_t *pgtable_t;
> #else
> typedef struct page *pgtable_t;
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix 64K page size support for PPC44x
2013-10-17 5:25 ` Aneesh Kumar K.V
@ 2013-10-17 5:47 ` Alistair Popple
0 siblings, 0 replies; 3+ messages in thread
From: Alistair Popple @ 2013-10-17 5:47 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Aneesh Kumar K.V
On Thu, 17 Oct 2013 10:55:25 Aneesh Kumar K.V wrote:
> Alistair Popple <alistair@popple.id.au> writes:
> > diff --git a/arch/powerpc/include/asm/page.h
> > b/arch/powerpc/include/asm/page.h index b9f4262..b142d58 100644
> > --- a/arch/powerpc/include/asm/page.h
> > +++ b/arch/powerpc/include/asm/page.h
> > @@ -403,7 +403,7 @@ void arch_free_page(struct page *page, int order);
> >
> > struct vm_area_struct;
> >
> > -#ifdef CONFIG_PPC_64K_PAGES
> > +#if defined(CONFIG_PPC_64K_PAGES) && defined(PPC64)
>
> ^^^ CONFIG_PPC64 ?
Yes, of course it should be. Thanks for picking that up - I'll send an updated
patch.
> > typedef pte_t *pgtable_t;
> > #else
> > typedef struct page *pgtable_t;
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-17 5:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-17 5:15 [PATCH] powerpc: Fix 64K page size support for PPC44x Alistair Popple
2013-10-17 5:25 ` Aneesh Kumar K.V
2013-10-17 5:47 ` Alistair Popple
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).