* [PATCH] powerpc/kexec_file: print error string on usable memory property update failure
@ 2022-12-16 12:27 Sourabh Jain
2022-12-19 8:46 ` Hari Bathini
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sourabh Jain @ 2022-12-16 12:27 UTC (permalink / raw)
To: linuxppc-dev, mpe; +Cc: mahesh, hbathini
Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.
Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
---
arch/powerpc/kexec/file_load_64.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
index 349a781cea0b3..7602f7e1e634e 100644
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem)
ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
um_info.buf, (um_info.idx * sizeof(u64)));
if (ret) {
- pr_err("Failed to update fdt with linux,drconf-usable-memory property");
+ pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s",
+ fdt_strerror(ret));
goto out;
}
}
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure
2022-12-16 12:27 [PATCH] powerpc/kexec_file: print error string on usable memory property update failure Sourabh Jain
@ 2022-12-19 8:46 ` Hari Bathini
2022-12-21 5:38 ` Sourabh Jain
2023-02-01 4:47 ` Sourabh Jain
2023-02-20 3:49 ` Michael Ellerman
2 siblings, 1 reply; 5+ messages in thread
From: Hari Bathini @ 2022-12-19 8:46 UTC (permalink / raw)
To: Sourabh Jain, linuxppc-dev, mpe; +Cc: mahesh
On 16/12/22 5:57 pm, Sourabh Jain wrote:
> Print the FDT error description along with the error message if failed
> to set the "linux,drconf-usable-memory" property in the kdump kernel's
> FDT.
>
> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
LGTM
Acked-by: Hari Bathini <hbathini@linux.ibm.com>
> ---
> arch/powerpc/kexec/file_load_64.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
> index 349a781cea0b3..7602f7e1e634e 100644
> --- a/arch/powerpc/kexec/file_load_64.c
> +++ b/arch/powerpc/kexec/file_load_64.c
> @@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem)
> ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
> um_info.buf, (um_info.idx * sizeof(u64)));
> if (ret) {
> - pr_err("Failed to update fdt with linux,drconf-usable-memory property");
> + pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s",
> + fdt_strerror(ret));
> goto out;
> }
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure
2022-12-19 8:46 ` Hari Bathini
@ 2022-12-21 5:38 ` Sourabh Jain
0 siblings, 0 replies; 5+ messages in thread
From: Sourabh Jain @ 2022-12-21 5:38 UTC (permalink / raw)
To: Hari Bathini, linuxppc-dev, mpe; +Cc: mahesh
On 19/12/22 14:16, Hari Bathini wrote:
>
>
> On 16/12/22 5:57 pm, Sourabh Jain wrote:
>> Print the FDT error description along with the error message if failed
>> to set the "linux,drconf-usable-memory" property in the kdump kernel's
>> FDT.
>>
>> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>
> LGTM
>
> Acked-by: Hari Bathini <hbathini@linux.ibm.com>
Thanks!
- Sourabh Jain
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure
2022-12-16 12:27 [PATCH] powerpc/kexec_file: print error string on usable memory property update failure Sourabh Jain
2022-12-19 8:46 ` Hari Bathini
@ 2023-02-01 4:47 ` Sourabh Jain
2023-02-20 3:49 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Sourabh Jain @ 2023-02-01 4:47 UTC (permalink / raw)
To: linuxppc-dev, mpe; +Cc: mahesh, hbathini
The only place on kexec/kdump path where we don't print
reason for FDT operation failure. This patch fix that.
Will this be a good candidate for next rc?
Thanks,
Sourabh
On 16/12/22 17:57, Sourabh Jain wrote:
> Print the FDT error description along with the error message if failed
> to set the "linux,drconf-usable-memory" property in the kdump kernel's
> FDT.
>
> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
> ---
> arch/powerpc/kexec/file_load_64.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
> index 349a781cea0b3..7602f7e1e634e 100644
> --- a/arch/powerpc/kexec/file_load_64.c
> +++ b/arch/powerpc/kexec/file_load_64.c
> @@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem)
> ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
> um_info.buf, (um_info.idx * sizeof(u64)));
> if (ret) {
> - pr_err("Failed to update fdt with linux,drconf-usable-memory property");
> + pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s",
> + fdt_strerror(ret));
> goto out;
> }
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure
2022-12-16 12:27 [PATCH] powerpc/kexec_file: print error string on usable memory property update failure Sourabh Jain
2022-12-19 8:46 ` Hari Bathini
2023-02-01 4:47 ` Sourabh Jain
@ 2023-02-20 3:49 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2023-02-20 3:49 UTC (permalink / raw)
To: mpe, Sourabh Jain, linuxppc-dev; +Cc: mahesh, hbathini
On Fri, 16 Dec 2022 17:57:08 +0530, Sourabh Jain wrote:
> Print the FDT error description along with the error message if failed
> to set the "linux,drconf-usable-memory" property in the kdump kernel's
> FDT.
>
>
Applied to powerpc/next.
[1/1] powerpc/kexec_file: print error string on usable memory property update failure
https://git.kernel.org/powerpc/c/b0ae5b6f3c298a005b73556740526c0e24a5633c
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-20 3:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-16 12:27 [PATCH] powerpc/kexec_file: print error string on usable memory property update failure Sourabh Jain
2022-12-19 8:46 ` Hari Bathini
2022-12-21 5:38 ` Sourabh Jain
2023-02-01 4:47 ` Sourabh Jain
2023-02-20 3:49 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).