From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
mikey@neuling.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 10/13] powerpc/ptrace: split out ADV_DEBUG_REGS related functions.
Date: Sat, 21 Mar 2020 10:27:59 +0000 [thread overview]
Message-ID: <25a7f050-f241-6035-e778-16b1ca9928f3@c-s.fr> (raw)
In-Reply-To: <87imizdbaz.fsf@mpe.ellerman.id.au>
On 03/20/2020 02:12 AM, Michael Ellerman wrote:
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>> Move ADV_DEBUG_REGS functions out of ptrace.c, into
>> ptrace-adv.c and ptrace-noadv.c
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> v4: Leave hw_breakpoint.h for ptrace.c
>> ---
>> arch/powerpc/kernel/ptrace/Makefile | 4 +
>> arch/powerpc/kernel/ptrace/ptrace-adv.c | 468 ++++++++++++++++
>> arch/powerpc/kernel/ptrace/ptrace-decl.h | 5 +
>> arch/powerpc/kernel/ptrace/ptrace-noadv.c | 236 ++++++++
>> arch/powerpc/kernel/ptrace/ptrace.c | 650 ----------------------
>> 5 files changed, 713 insertions(+), 650 deletions(-)
>> create mode 100644 arch/powerpc/kernel/ptrace/ptrace-adv.c
>> create mode 100644 arch/powerpc/kernel/ptrace/ptrace-noadv.c
>
> This is somehow breaking the ptrace-hwbreak selftest on Power8:
>
> test: ptrace-hwbreak
> tags: git_version:v5.6-rc6-892-g7a285a6067d6
> PTRACE_SET_DEBUGREG, WO, len: 1: Ok
> PTRACE_SET_DEBUGREG, WO, len: 2: Ok
> PTRACE_SET_DEBUGREG, WO, len: 4: Ok
> PTRACE_SET_DEBUGREG, WO, len: 8: Ok
> PTRACE_SET_DEBUGREG, RO, len: 1: Ok
> PTRACE_SET_DEBUGREG, RO, len: 2: Ok
> PTRACE_SET_DEBUGREG, RO, len: 4: Ok
> PTRACE_SET_DEBUGREG, RO, len: 8: Ok
> PTRACE_SET_DEBUGREG, RW, len: 1: Ok
> PTRACE_SET_DEBUGREG, RW, len: 2: Ok
> PTRACE_SET_DEBUGREG, RW, len: 4: Ok
> PTRACE_SET_DEBUGREG, RW, len: 8: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_EXACT, WO, len: 1: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RO, len: 1: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RW, len: 1: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, WO, len: 6: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RO, len: 6: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RW, len: 6: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW UNALIGNED, WO, len: 6: Ok
> PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW UNALIGNED, RO, len: 6: Fail
> failure: ptrace-hwbreak
>
> I haven't had time to work out why yet.
>
A (big) part of commit c3f68b0478e7 ("powerpc/watchpoint: Fix ptrace
code that muck around with address/len") was lost during rebase.
I'll send a fix, up to you to squash it in or commit it as is.
Christophe
next prev parent reply other threads:[~2020-03-21 10:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 0:14 [PATCH v5 00/13] Reduce ifdef mess in ptrace Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 01/13] powerpc: move ptrace into a subdirectory Christophe Leroy
2020-04-01 12:53 ` Michael Ellerman
2020-02-28 0:14 ` [PATCH v5 02/13] powerpc/ptrace: remove unused header includes Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 03/13] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64 Christophe Leroy
2020-03-30 13:31 ` Balamuruhan S
2020-02-28 0:14 ` [PATCH v5 04/13] powerpc/ptrace: drop PARAMETER_SAVE_AREA_OFFSET Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 05/13] powerpc/ptrace: split out VSX related functions Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 06/13] powerpc/ptrace: split out ALTIVEC " Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 07/13] powerpc/ptrace: split out SPE " Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 08/13] powerpc/ptrace: split out TRANSACTIONAL_MEM " Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 09/13] powerpc/ptrace: move register viewing functions out of ptrace.c Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 10/13] powerpc/ptrace: split out ADV_DEBUG_REGS related functions Christophe Leroy
2020-03-20 2:12 ` Michael Ellerman
2020-03-21 10:27 ` Christophe Leroy [this message]
2020-03-24 6:23 ` Michael Ellerman
2020-03-26 12:53 ` Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 11/13] powerpc/ptrace: create ptrace_get_debugreg() Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 12/13] powerpc/ptrace: create ppc_gethwdinfo() Christophe Leroy
2020-02-28 0:14 ` [PATCH v5 13/13] powerpc/ptrace: move ptrace_triggered() into hw_breakpoint.c Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25a7f050-f241-6035-e778-16b1ca9928f3@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).