linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Harry Ciao <qingtao.cao@windriver.com>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] Maple: register CPC925 EDAC device on all boards with CPC925
Date: Sat, 21 May 2011 15:09:19 +0200	[thread overview]
Message-ID: <2825c3704d46eca735f20b01be7e33f9@kernel.crashing.org> (raw)
In-Reply-To: <1305973871-28244-1-git-send-email-dbaryshkov@gmail.com>

> Currently Maple setup code creates cpc925_edac device only on
> Motorola ATCA-6101 blade. Make setup code check bridge revision
> and enable EDAC on all U3 bridges.

But the EDAC code only works on U3H (CPC925), not old U3.

> +	if ((rev & 0xf0) != 0x30) { /* U3 */
> +		printk(KERN_ERR "%s: Non-CPC925(U3) bridge revision: %02x\n",

Should be:  if (rev >= 0x34 && rev <= 0x3f)


Segher

  parent reply	other threads:[~2011-05-21 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21 10:31 [PATCH 1/2] Maple: register CPC925 EDAC device on all boards with CPC925 Dmitry Eremin-Solenikov
2011-05-21 10:31 ` [PATCH 2/2] cpc925_edac: support single-processor configurations Dmitry Eremin-Solenikov
2011-05-21 11:33   ` Dmitry Eremin-Solenikov
2011-05-21 13:45     ` Segher Boessenkool
2011-05-21 18:15       ` Dmitry Eremin-Solenikov
2011-05-21 20:04         ` Segher Boessenkool
2011-05-22  9:12           ` Dmitry Eremin-Solenikov
2011-05-21 13:09 ` Segher Boessenkool [this message]
2011-05-21 18:15   ` [PATCH 1/2] Maple: register CPC925 EDAC device on all boards with CPC925 Dmitry Eremin-Solenikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2825c3704d46eca735f20b01be7e33f9@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dbaryshkov@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=qingtao.cao@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).