From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Harry Ciao <qingtao.cao@windriver.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
Doug Thompson <dougthompson@xmission.com>
Subject: Re: [PATCH 2/2] cpc925_edac: support single-processor configurations
Date: Sat, 21 May 2011 22:15:13 +0400 [thread overview]
Message-ID: <BANLkTimCq6zOtZ3LYKdXLsvqr5SVeMnsDg@mail.gmail.com> (raw)
In-Reply-To: <cca27f630fb5e3388eef060ea784f024@kernel.crashing.org>
On 5/21/11, Segher Boessenkool <segher@kernel.crashing.org> wrote:
>> If second CPU is not enabled, CPC925 EDAC driver will spill out
>> warnings
>> about errors on second Processor Interface. Support masking that out,
>> by detecting at runtime which CPUs are present in device tree.
>
> That doesn't quite work, there can be multiple CPUs per processor
> interface.
Are you sure that there can be multiple CPUs on one PI with CPC925
(CPC945 isn't supported by this driver anyway, IIUC).
> You should be able to see which interfaces are enabled in some CPC925
> register,
> but maybe both _are_ enabled on your system (although one is not
> connected),
> which is causing the errors?
Hmm, I dont't think this is the case: I'm using a MapleD board with two CPUs
connected to separate PIs. However I can slect the service processor
to enable only one CPU via selecting correct bootscript. In this case
bootscript correctly enables only APIMASK_ADI0. However as cpc925_edac
checks the APIEXCP itself, it sees the APIEXCP_ADI1 bit set and spills
regular warnings about it (see below).
If you'd prefer I can add a check for APIMASK at cpc925_cpu_init() time,
but I think that this will be less robust.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2011-05-21 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 10:31 [PATCH 1/2] Maple: register CPC925 EDAC device on all boards with CPC925 Dmitry Eremin-Solenikov
2011-05-21 10:31 ` [PATCH 2/2] cpc925_edac: support single-processor configurations Dmitry Eremin-Solenikov
2011-05-21 11:33 ` Dmitry Eremin-Solenikov
2011-05-21 13:45 ` Segher Boessenkool
2011-05-21 18:15 ` Dmitry Eremin-Solenikov [this message]
2011-05-21 20:04 ` Segher Boessenkool
2011-05-22 9:12 ` Dmitry Eremin-Solenikov
2011-05-21 13:09 ` [PATCH 1/2] Maple: register CPC925 EDAC device on all boards with CPC925 Segher Boessenkool
2011-05-21 18:15 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimCq6zOtZ3LYKdXLsvqr5SVeMnsDg@mail.gmail.com \
--to=dbaryshkov@gmail.com \
--cc=dougthompson@xmission.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qingtao.cao@windriver.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).